From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CCCAC46467 for ; Tue, 29 Nov 2022 12:38:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234395AbiK2MiV (ORCPT ); Tue, 29 Nov 2022 07:38:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230128AbiK2MiU (ORCPT ); Tue, 29 Nov 2022 07:38:20 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F2A2303ED for ; Tue, 29 Nov 2022 04:38:19 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5DFF14E6; Tue, 29 Nov 2022 13:38:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1669725497; bh=iiXEMJmYkobicYzVrgEOHcFIFq/zwPSyahHj3ZvZlzE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z1AYEEQHuNBEIv74qC8NJz7QelXyaKbA5rVMauu0GsNI9x9jZIlf897I2x7b3OU4y nCCMPhp0fPT9Jt3JgYOE0ADHk7+G1Xpahqcto7Ja7mMzFtmua0LMcFvCA2O5+GKEBI 7IKvlBNAlQTeqGLGMaTIVo2i3mhKD4/cB2Ka97kg= Date: Tue, 29 Nov 2022 14:38:01 +0200 From: Laurent Pinchart To: Maxime Ripard Cc: Emma Anholt , Maxime Ripard , Rob Herring , Daniel Vetter , Eric Anholt , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Joerg Quinten , Chris Morgan , Dave Stevenson Subject: Re: [PATCH v2 3/7] media: uapi: add MEDIA_BUS_FMT_BGR666_1X24_CPADHI Message-ID: References: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> <20221013-rpi-dpi-improvements-v2-3-7691903fb9c8@cerno.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221013-rpi-dpi-improvements-v2-3-7691903fb9c8@cerno.tech> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime and Joerg, Thank you for the patch. On Thu, Oct 20, 2022 at 10:30:47AM +0200, Maxime Ripard wrote: > From: Joerg Quinten > > Add the BGR666 format MEDIA_BUS_FMT_BGR666_1X24_CPADHI supported by the > RaspberryPi. > > Signed-off-by: Joerg Quinten > Signed-off-by: Maxime Ripard > --- > .../userspace-api/media/v4l/subdev-formats.rst | 37 ++++++++++++++++++++++ > include/uapi/linux/media-bus-format.h | 3 +- > 2 files changed, 39 insertions(+), 1 deletion(-) > > diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.rst b/Documentation/userspace-api/media/v4l/subdev-formats.rst > index 68f8d7d37984..604a30e2f890 100644 > --- a/Documentation/userspace-api/media/v4l/subdev-formats.rst > +++ b/Documentation/userspace-api/media/v4l/subdev-formats.rst > @@ -1023,6 +1023,43 @@ The following tables list existing packed RGB formats. > - g\ :sub:`2` > - g\ :sub:`1` > - g\ :sub:`0` > + * .. _MEDIA-BUS-FMT-BGR666-1X24_CPADHI: I would move this just below MEDIA_BUS_FMT_RGB565_1X24_CPADHI. Actually, could you check 1/7 and 2/7 to make sure the formats are sorted in the documentation in the same order as in the header ? > + > + - MEDIA_BUS_FMT_BGR666_1X24_CPADHI > + - 0x1024 > + - > + - > + - > + - > + - > + - > + - > + - > + - > + - 0 > + - 0 > + - b\ :sub:`5` > + - b\ :sub:`4` > + - b\ :sub:`3` > + - b\ :sub:`2` > + - b\ :sub:`1` > + - b\ :sub:`0` > + - 0 > + - 0 > + - g\ :sub:`5` > + - g\ :sub:`4` > + - g\ :sub:`3` > + - g\ :sub:`2` > + - g\ :sub:`1` > + - g\ :sub:`0` > + - 0 > + - 0 > + - r\ :sub:`5` > + - r\ :sub:`4` > + - r\ :sub:`3` > + - r\ :sub:`2` > + - r\ :sub:`1` > + - r\ :sub:`0` > * .. _MEDIA-BUS-FMT-RGB565-1X24_CPADHI: > > - MEDIA_BUS_FMT_RGB565_1X24_CPADHI > diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h > index 2ee0b38c0a71..d4228d038b54 100644 > --- a/include/uapi/linux/media-bus-format.h > +++ b/include/uapi/linux/media-bus-format.h > @@ -34,7 +34,7 @@ > > #define MEDIA_BUS_FMT_FIXED 0x0001 > > -/* RGB - next is 0x1024 */ > +/* RGB - next is 0x1025 */ > #define MEDIA_BUS_FMT_RGB444_1X12 0x1016 > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 > @@ -49,6 +49,7 @@ > #define MEDIA_BUS_FMT_BGR666_1X18 0x1023 > #define MEDIA_BUS_FMT_RGB666_1X18 0x1009 > #define MEDIA_BUS_FMT_RBG888_1X24 0x100e > +#define MEDIA_BUS_FMT_BGR666_1X24_CPADHI 0x1024 > #define MEDIA_BUS_FMT_RGB666_1X24_CPADHI 0x1015 > #define MEDIA_BUS_FMT_RGB666_1X7X3_SPWG 0x1010 > #define MEDIA_BUS_FMT_BGR888_1X24 0x1013 > -- Regards, Laurent Pinchart