From: Nathan Chancellor <nathan@kernel.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Cc: agross@kernel.org, andersson@kernel.org, lgirdwood@gmail.com,
broonie@kernel.org, robh+dt@kernel.org, quic_plai@quicinc.com,
bgoswami@quicinc.com, perex@perex.cz, tiwai@suse.com,
srinivas.kandagatla@linaro.org, quic_rohkumar@quicinc.com,
linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, swboyd@chromium.org,
judyhsiao@chromium.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] ASoC: qcom: lpass-sc7180: Add maybe_unused tag for system PM ops
Date: Tue, 29 Nov 2022 09:05:46 -0700 [thread overview]
Message-ID: <Y4Yt2oEZm+Yb/wyr@dev-arch.thelio-3990X> (raw)
In-Reply-To: <65fd2068-4744-221f-f398-da4303b64fca@quicinc.com>
On Tue, Nov 29, 2022 at 09:28:33PM +0530, Srinivasa Rao Mandadapu wrote:
> Thanks for your tie Nathan!!!
>
> On 11/29/2022 9:15 PM, Nathan Chancellor wrote:
> > On Tue, Nov 29, 2022 at 06:23:48PM +0530, Srinivasa Rao Mandadapu wrote:
> > > Add __maybe_unused tag for system PM ops suspend and resume.
> > > This is required to fix allmodconfig compilation issue.
> > > Fixes: c3bf7699747c ("ASoC: qcom: lpass-sc7280: Add system suspend/resume PM ops")
> > >
> > > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> > A better solution would be replacing SET_SYSTEM_SLEEP_PM_OPS() with
> > SYSTEM_SLEEP_PM_OPS(), which was added to avoid needing to add these
> > '__maybe_unused' attributes to these functions. See commit 1a3c7bb08826
> > ("PM: core: Add new *_PM_OPS macros, deprecate old ones") for more info.
>
> Tried this option but as this patch required for Kernel 5.4 version code
> base,
>
> SYSTEM_SLEEP_PM_OPS didn't work.
Ah right, it is a more recent macro. I did not realize this patch was
needed to fix a patch destined for stable.
Perhaps keep this patch but add a second patch after it that converts
to using SYSTEM_SLEEP_PM_OPS() for future releases?
> > > ---
> > > sound/soc/qcom/lpass-sc7180.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c
> > > index b96b85a..41db661 100644
> > > --- a/sound/soc/qcom/lpass-sc7180.c
> > > +++ b/sound/soc/qcom/lpass-sc7180.c
> > > @@ -163,14 +163,14 @@ static int sc7180_lpass_exit(struct platform_device *pdev)
> > > return 0;
> > > }
> > > -static int sc7180_lpass_dev_resume(struct device *dev)
> > > +static int __maybe_unused sc7180_lpass_dev_resume(struct device *dev)
> > > {
> > > struct lpass_data *drvdata = dev_get_drvdata(dev);
> > > return clk_bulk_prepare_enable(drvdata->num_clks, drvdata->clks);
> > > }
> > > -static int sc7180_lpass_dev_suspend(struct device *dev)
> > > +static int __maybe_unused sc7180_lpass_dev_suspend(struct device *dev)
> > > {
> > > struct lpass_data *drvdata = dev_get_drvdata(dev);
> > > --
> > > 2.7.4
> > >
> > >
next prev parent reply other threads:[~2022-11-29 16:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 12:53 Srinivasa Rao Mandadapu
2022-11-29 14:43 ` Mark Brown
2022-11-29 15:40 ` Mark Brown
2022-11-29 15:45 ` Nathan Chancellor
2022-11-29 15:58 ` Srinivasa Rao Mandadapu
2022-11-29 16:05 ` Nathan Chancellor [this message]
2022-11-29 20:08 ` Matthias Kaehlcke
2022-12-01 7:02 ` Srinivasa Rao Mandadapu
2022-11-30 17:07 ` Matthias Kaehlcke
2022-11-30 17:16 ` Mark Brown
2022-11-30 17:37 ` Matthias Kaehlcke
2022-11-30 19:12 ` Mark Brown
2022-12-01 3:31 ` Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4Yt2oEZm+Yb/wyr@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®