From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54D5DC433FE for ; Tue, 29 Nov 2022 18:45:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236108AbiK2Spj (ORCPT ); Tue, 29 Nov 2022 13:45:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230346AbiK2Spe (ORCPT ); Tue, 29 Nov 2022 13:45:34 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB810220D2; Tue, 29 Nov 2022 10:45:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=eBWuh73tk9XJat2zMB8IWchuBJYyyUZAlX9rylZctiU=; b=dZIH6KeddKTB+s6/ptXQkZ+1ya krekgr2RMH5VD/WsdYE/RYOmu4T6co1rOLxOxprHx534rnuBzwtoCOydat60bBILyJDffmSwycgmn 2h7xmPMIGc8UB5JopdK3YkoKG9JQEtSd6D7/Gac/N9nFTeVlklqyC7dUob6KoSipmrXU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1p05bm-003u3h-EF; Tue, 29 Nov 2022 19:45:30 +0100 Date: Tue, 29 Nov 2022 19:45:30 +0100 From: Andrew Lunn To: Hariprasad Kelam Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, sgoutham@marvell.com, lcherian@marvell.com, gakula@marvell.com, jerinj@marvell.com, sbhatta@marvell.com Subject: Re: [net-next PATCH V2 3/4] octeontx2-pf: ethtool: Implement get_fec_stats Message-ID: References: <20221129051409.20034-1-hkelam@marvell.com> <20221129051409.20034-4-hkelam@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221129051409.20034-4-hkelam@marvell.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 29, 2022 at 10:44:08AM +0530, Hariprasad Kelam wrote: > The current implementation is such that FEC statistics are reported as > part of ethtool statistics that is the user can fetch them from the > below command > > "ethtool -S eth0" > > Fec Corrected Errors: > Fec Uncorrected Errors: > > This patch removes this logic What might break the ABI, if anybody is using these statistics, or has a dumb parser and just looks at entry 42 which is now a different entry. So i think you need to keep these two, and additionally report them the correct way via get_fec_stats. Andrew