From: Daniel Vetter <daniel@ffwll.ch>
To: Rob Clark <robdclark@gmail.com>
Cc: dri-devel@lists.freedesktop.org,
"Daniel Vetter" <daniel@ffwll.ch>,
"Rob Clark" <robdclark@chromium.org>,
stable@vger.kernel.org,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Eric Anholt" <eric@anholt.net>,
"Noralf Trønnes" <noralf@tronnes.org>,
"Rob Herring" <robh@kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] drm/shmem-helper: Remove errant put in error path
Date: Wed, 30 Nov 2022 12:19:08 +0100 [thread overview]
Message-ID: <Y4c8LMIkGPoPGy+4@phenom.ffwll.local> (raw)
In-Reply-To: <20221129200242.298120-2-robdclark@gmail.com>
On Tue, Nov 29, 2022 at 12:02:41PM -0800, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> drm_gem_shmem_mmap() doesn't own this reference!
>
> Fixes: 2194a63a818d ("drm: Add library for shmem backed GEM objects")
> Cc: stable@vger.kernel.org
> Signed-off-by: Rob Clark <robdclark@chromium.org>
With Guenter's nits addressed:
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/drm_gem_shmem_helper.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index 35138f8a375c..110a9eac2af8 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -623,7 +623,6 @@ int drm_gem_shmem_mmap(struct drm_gem_shmem_object *shmem, struct vm_area_struct
>
> ret = drm_gem_shmem_get_pages(shmem);
> if (ret) {
> - drm_gem_vm_close(vma);
> return ret;
> }
>
> --
> 2.38.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2022-11-30 11:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 20:02 [PATCH 0/2] drm/shmem-helper: Fix a couple of error path bugs Rob Clark
2022-11-29 20:02 ` [PATCH 1/2] drm/shmem-helper: Remove errant put in error path Rob Clark
2022-11-29 20:13 ` [1/2] " Guenter Roeck
2022-11-30 11:19 ` Daniel Vetter [this message]
2022-11-29 20:02 ` [PATCH 2/2] drm/shmem-helper: Avoid vm_open error paths Rob Clark
2022-11-29 20:32 ` [2/2] " Guenter Roeck
2022-11-29 20:47 ` Rob Clark
2022-11-30 0:13 ` Guenter Roeck
2022-11-30 11:21 ` Daniel Vetter
2022-11-30 14:03 ` [PATCH 2/2] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4c8LMIkGPoPGy+4@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=noralf@tronnes.org \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®