From: Andrew Lunn <andrew@lunn.ch>
To: Jerry.Ray@microchip.com
Cc: olteanv@gmail.com, f.fainelli@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3] dsa: lan9303: Add 3 ethtool stats
Date: Wed, 30 Nov 2022 17:00:41 +0100 [thread overview]
Message-ID: <Y4d+KcqQQzKBpo8z@lunn.ch> (raw)
In-Reply-To: <MWHPR11MB1693C29AFEAE5386D0EE3AEFEF159@MWHPR11MB1693.namprd11.prod.outlook.com>
On Wed, Nov 30, 2022 at 03:57:35PM +0000, Jerry.Ray@microchip.com wrote:
> >> static void lan9303_get_ethtool_stats(struct dsa_switch *ds, int port,
> >> uint64_t *data)
> >> {
> >> struct lan9303 *chip = ds->priv;
> >> - unsigned int u;
> >> + unsigned int i, u;
> >>
> >> for (u = 0; u < ARRAY_SIZE(lan9303_mib); u++) {
> >> u32 reg;
> >> int ret;
> >>
> >> - ret = lan9303_read_switch_port(
> >> - chip, port, lan9303_mib[u].offset, ®);
> >> -
> >> + /* Read Port-based MIB stats. */
> >> + ret = lan9303_read_switch_port(chip, port,
> >> + lan9303_mib[u].offset,
> >> + ®);
> >
> >Speaking of unrelated changes...
> >
>
> Cleaning up a warning generated from checkpatch
Cleanups a good, but please put them in a patch of their own.
https://www.kernel.org/doc/html/v4.10/process/submitting-patches.html#separate-your-changes
3) Separate your changes
Separate each logical change into a separate patch.
Andrew
next prev parent reply other threads:[~2022-11-30 16:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 20:55 Jerry Ray
2022-11-28 21:05 ` Vladimir Oltean
2022-11-30 15:57 ` Jerry.Ray
2022-11-30 16:00 ` Andrew Lunn [this message]
2022-11-28 23:21 ` Jakub Kicinski
2022-11-30 15:51 ` Jerry.Ray
2022-11-30 16:52 ` Jakub Kicinski
2022-11-30 18:12 ` Jerry.Ray
2022-11-30 18:50 ` Vladimir Oltean
2022-12-01 15:56 ` Jerry.Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4d+KcqQQzKBpo8z@lunn.ch \
--to=andrew@lunn.ch \
--cc=Jerry.Ray@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®