From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49EFFC43217 for ; Thu, 1 Dec 2022 10:16:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229835AbiLAKQl (ORCPT ); Thu, 1 Dec 2022 05:16:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229597AbiLAKQi (ORCPT ); Thu, 1 Dec 2022 05:16:38 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC7599077C for ; Thu, 1 Dec 2022 02:16:36 -0800 (PST) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E331A1FD63; Thu, 1 Dec 2022 10:16:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669889794; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4jR5csyqPRlj0sE4agPtfCNXgK7gme6BxDCQeVvGkkg=; b=Arxdm3h4gzmt1gTKhaLwG4RIVX3FDKwQeQEzMM1qMA3TQ+STnD9rulwoPW6U9A5FNAFzWO 96knByfeGJDSX1ItF82uOYf7fdEfB0EDg3IGKcmbBKsKuEF9MOZ8CP6Mx7uPIUrxUyUuJ0 bUvVIteBr9k3tk2DH2jFG+tdoXzSQ8k= Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id D36DA13503; Thu, 1 Dec 2022 10:16:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id bwbIMgJ/iGMbJwAAGKfGzw (envelope-from ); Thu, 01 Dec 2022 10:16:34 +0000 Date: Thu, 1 Dec 2022 11:16:34 +0100 From: Michal Hocko To: kernel test robot Cc: Shakeel Butt , oe-lkp@lists.linux.dev, lkp@intel.com, Andrew Morton , kernel test robot , Soheil Hassas Yeganeh , Feng Tang , Roman Gushchin , Muchun Song , Eric Dumazet , Johannes Weiner , Michal =?iso-8859-1?Q?Koutn=FD?= , linux-kernel@vger.kernel.org Subject: Re: [linus:master] [memcg] 1813e51eec: kernel-selftests.cgroup.test_kmem.test_kmem_memcg_deletion.fail Message-ID: References: <202212010958.c1053bd3-yujie.liu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202212010958.c1053bd3-yujie.liu@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 01-12-22 16:05:44, kernel test robot wrote: > Greeting, > > FYI, we noticed kernel-selftests.cgroup.test_kmem.test_kmem_memcg_deletion.fail due to commit (built with gcc-11): > > commit: 1813e51eece0ad6f4aacaeb738e7cced46feb470 ("memcg: increase MEMCG_CHARGE_BATCH to 64") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > [test failed on linux-next/master 700e0cd3a5ce6a2cb90d9a2aab729b52f092a7d6] > > in testcase: kernel-selftests > version: kernel-selftests-x86_64-2ed09c3b-1_20221128 > with following parameters: > > group: cgroup > > test-description: The kernel contains a set of "self tests" under the tools/testing/selftests/ directory. These are intended to be small unit tests to exercise individual code paths in the kernel. > test-url: https://www.kernel.org/doc/Documentation/kselftest.txt > > on test machine: 128 threads 2 sockets Intel(R) Xeon(R) Platinum 8358 CPU @ 2.60GHz (Ice Lake) with 128G memory > > caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace): > > > # memory.current = 40161280 > # slab + anon + file + kernel_stack = 14478624 > # slab = 13453184 > # anon = 0 > # file = 0 > # kernel_stack = 0 > # pagetables = 0 > # percpu = 1025440 > # sock = 0 > # not ok 2 test_kmem_memcg_deletion <-- > # ok 3 test_kmem_proc_kpagecgroup > # ok 4 test_kmem_kernel_stacks > # ok 5 test_kmem_dead_cgroups > # ok 6 test_percpu_basic > not ok 2 selftests: cgroup: test_kmem # exit=1 IIUC we need this diff --git a/tools/testing/selftests/cgroup/test_kmem.c b/tools/testing/selftests/cgroup/test_kmem.c index 22b31ebb3513..1d073e28254b 100644 --- a/tools/testing/selftests/cgroup/test_kmem.c +++ b/tools/testing/selftests/cgroup/test_kmem.c @@ -24,7 +24,7 @@ * the maximum discrepancy between charge and vmstat entries is number * of cpus multiplied by 32 pages. */ -#define MAX_VMSTAT_ERROR (4096 * 32 * get_nprocs()) +#define MAX_VMSTAT_ERROR (4096 * 64 * get_nprocs()) static int alloc_dcache(const char *cgroup, void *arg) But honestly, I am rather dubious of tests like this one. Does it really give us any useful testing coverage? -- Michal Hocko SUSE Labs