From: Johan Hovold <johan@kernel.org>
To: Jack Schofield <schofija@oregonstate.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] staging: greybus: Cleanups in loopback_test
Date: Thu, 1 Dec 2022 08:17:06 +0100 [thread overview]
Message-ID: <Y4hU8oC7H5h6G2ZI@hovoldconsulting.com> (raw)
In-Reply-To: <cover.1669872193.git.schofija@oregonstate.edu>
On Wed, Nov 30, 2022 at 09:38:49PM -0800, Jack Schofield wrote:
> Correct issues found by checkpatch.
>
> Jack Schofield (3):
> staging: greybus: loopback_test: Add blank line after declaration.
Nit: no need for a full stop in the commit summary.
> staging: greybus: loopback_test: Remove void function return statement
> staging: greybus: loopback_test: Remove extra blank lines
>
> drivers/staging/greybus/tools/loopback_test.c | 15 +--------------
> 1 file changed, 1 insertion(+), 14 deletions(-)
Other than that, all of these look good to me:
Reviewed-by: Johan Hovold <johan@kernel.org>
Johan
next prev parent reply other threads:[~2022-12-01 7:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 5:38 Jack Schofield
2022-12-01 5:38 ` [PATCH 1/3] staging: greybus: loopback_test: Add blank line after declaration Jack Schofield
2022-12-01 5:38 ` [PATCH 2/3] staging: greybus: loopback_test: Remove void function return statement Jack Schofield
2022-12-01 5:38 ` [PATCH 3/3] staging: greybus: loopback_test: Remove extra blank lines Jack Schofield
2022-12-01 7:17 ` Johan Hovold [this message]
2022-12-02 1:33 ` [PATCH 0/3] staging: greybus: Cleanups in loopback_test Jack Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4hU8oC7H5h6G2ZI@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=schofija@oregonstate.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®