Re: [PATCH 5.10 000/162] 5.10.157-rc1 review

[Pavel Machek <pavel@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1566 bytes --]

Hi!

[If I cc-ed you, you are author of one of patches below. Please take a
look.]

> Responses should be made by Fri, 02 Dec 2022 18:05:05 +0000.
> Anything received after that time might be too late.

I hope to make it :-). I

> Pawel Laszczak <pawell@cadence.com>
>     usb: cdnsp: Device side header file for CDNSP driver
> 
> Pawel Laszczak <pawell@cadence.com>
>     usb: cdns3: Add support for DRD CDNSP

These two together are 1500+ lines, and are marked as Stable-dep-of:
9d5333c93134 ("usb: cdns3: host: fix endless superspeed hub port
reset") . But we don't have that one in 5.10 tree. Likely we should
not have these either.

> Maxim Levitsky <mlevitsk@redhat.com>
>     KVM: x86: emulator: update the emulation mode after rsm

No. The patch does not do anything. Mainline commit this referenced
changed the return value, this changes just a comment. Wrong backport?

> Samuel Thibault <samuel.thibault@ens-lyon.org>
>     speakup: Generate speakupmap.h automatically

Ok, so this one rewrites some header generation and is buggy. 500+ lines.

> Đoàn Trần Công Danh <congdanhqx@gmail.com>
>     speakup: replace utils' u_char with unsigned char

With this patch fixing it. The rewrite is marked as stable depedncency
of the fix, but fix would not be needed if we did not apply the
rewrite. We should not have these two in stable.

Best regards,
								Pavel

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]