From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC990C4332F for ; Sun, 4 Dec 2022 09:44:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230030AbiLDJom (ORCPT ); Sun, 4 Dec 2022 04:44:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230044AbiLDJoe (ORCPT ); Sun, 4 Dec 2022 04:44:34 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 845BF186C7; Sun, 4 Dec 2022 01:44:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 20058B80813; Sun, 4 Dec 2022 09:44:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB880C433D6; Sun, 4 Dec 2022 09:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1670147070; bh=EZT67/m18c2otgDWsLEQDZEinTscEZxP03Tjfwybbwk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r7CwKuivyjZxBtQjwQjV5P8lpVHTFhVHSNJTM+YygtEIEVEKZN6MKZc2Na3lYojPJ 9tkVZReH+dcMCgxgv3lvmKOwVoPY2wiV6d9V/HIBSoiyOfZFF+PEy+o+S6Sib5o/nb ONieB93kYA7A96zGIkn8J7XdyrwLY017s8hsYyrg= Date: Sun, 4 Dec 2022 10:44:26 +0100 From: Greg KH To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= Cc: linux-fpga@vger.kernel.org, Xu Yilun , Wu Hao , Tom Rix , Moritz Fischer , Lee Jones , Matthew Gerlach , Russ Weight , Tianfei zhang , Mark Brown , Marco Pagani , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 9/9] mfd: intel-m10-bmc: Change MODULE_LICENSE() to GPL Message-ID: References: <20221202100841.4741-1-ilpo.jarvinen@linux.intel.com> <20221202100841.4741-10-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221202100841.4741-10-ilpo.jarvinen@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 02, 2022 at 12:08:41PM +0200, Ilpo Järvinen wrote: > "GPL v2" should not be used as MODULE_LICENSE(). "GPL" is enough, see > commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL > v2" bogosity") for more details. And that commit says that leaving "GPL v2" is just fine and dandy and should not be an issue at all. Please do not change the license for no good reason. That commit is NOT a good reason to change it at all. so NAK on this patch, sorry. greg k-h