From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: mc: entity: Fix doc for media_graph_walk_init
Date: Sun, 18 Dec 2022 16:22:21 +0200 [thread overview]
Message-ID: <Y58iHWVAUIwmH/4b@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20221217143113.3219104-1-linmq006@gmail.com>
Hi Miaoqian,
Thank you for the patch.
On Sat, Dec 17, 2022 at 06:31:13PM +0400, Miaoqian Lin wrote:
> There is no media_graph_walk_free(). media_graph_walk_cleanup() is used
> to release the resources.
>
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/media/mc/mc-entity.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c
> index b8bcbc734eaf..de25de328fbe 100644
> --- a/drivers/media/mc/mc-entity.c
> +++ b/drivers/media/mc/mc-entity.c
> @@ -295,7 +295,7 @@ static struct media_entity *stack_pop(struct media_graph *graph)
> *
> * Reserve resources for graph walk in media device's current
> * state. The memory must be released using
> - * media_graph_walk_free().
> + * media_graph_walk_cleanup().
> *
> * Returns error on failure, zero on success.
> */
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2022-12-18 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 14:31 Miaoqian Lin
2022-12-18 14:22 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y58iHWVAUIwmH/4b@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®