From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EBAAC352A1 for ; Wed, 7 Dec 2022 14:07:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230215AbiLGOHx (ORCPT ); Wed, 7 Dec 2022 09:07:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230242AbiLGOHV (ORCPT ); Wed, 7 Dec 2022 09:07:21 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F22162F5; Wed, 7 Dec 2022 06:07:20 -0800 (PST) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CDAC921D6F; Wed, 7 Dec 2022 14:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1670422038; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tosjZfZODydjUbuqrfEIBGsRjeHYQJ8iIC4GtSX4HdI=; b=Dzp6vahbk3af6y9m0wtHT4j/LM+TyWTrbJIuLUyzPAbc24XF/CBB1eIm3UDK4IGhqwI+mj YIpJgQTcYIhAkzTYqDboGt/kD5Qs0wi5JejZgTgYXEQGBipL0FKzPZWbIw15KxDOL4Pufn QLs/PPjzoH1pMZyBiKRFSJZzF1m3LC4= Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id AAAC6136B4; Wed, 7 Dec 2022 14:07:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id D00+JxaekGOvBwAAGKfGzw (envelope-from ); Wed, 07 Dec 2022 14:07:18 +0000 Date: Wed, 7 Dec 2022 15:07:18 +0100 From: Michal Hocko To: Johannes Weiner Cc: Andrew Morton , Linus Torvalds , Hugh Dickins , Shakeel Butt , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] mm: push down lock_page_memcg() Message-ID: References: <20221206171340.139790-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221206171340.139790-1-hannes@cmpxchg.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 06-12-22 18:13:38, Johannes Weiner wrote: > New series based on the discussion in the previous thread around > getting lock_page_memcg() out of rmap. > > I beat on this with concurrent high-frequency moving of tasks that > partially share a swapped out shmem file. I didn't spot anything > problematic. That said, it is quite subtle, and Hugh, I'd feel better > if you could also subject it to your torture suite ;) For the whole series Acked-by: Michal Hocko Thanks! > > Thanks! > > Against yesterday's mm-unstable. > > Documentation/admin-guide/cgroup-v1/memory.rst | 11 ++++- > mm/memcontrol.c | 56 ++++++++++++++++++------ > mm/rmap.c | 26 ++++------- > 3 files changed, 60 insertions(+), 33 deletions(-) > -- Michal Hocko SUSE Labs