From: Pavel Machek <pavel@ucw.cz>
To: Luca Weiss <luca@z3ntu.xyz>
Cc: linux-leds@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
Vincent Knecht <vincent.knecht@mailoo.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: is31fl319x: Fix setting current limit for is31fl319{0,1,3}
Date: Wed, 7 Dec 2022 21:03:46 +0100 [thread overview]
Message-ID: <Y5DxoqlDdcOma+jC@duo.ucw.cz> (raw)
In-Reply-To: <20221129212901.1049085-1-luca@z3ntu.xyz>
[-- Attachment #1: Type: text/plain, Size: 579 bytes --]
On Tue 2022-11-29 22:29:01, Luca Weiss wrote:
> The current setting lives in bits 4:2 (as also defined by the mask) but
> the current limit defines in the driver use bits 2:0 which should be
> shifted over so they don't get masked out completely (except for 17.5mA
> which became 10mA).
>
> Now checking /sys/kernel/debug/regmap/1-0068/registers shows that the
> current limit is applied correctly and doesn't take the default b000 =
> 42mA.
Thank you, applied.
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2022-12-07 20:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 21:29 Luca Weiss
2022-12-07 20:03 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5DxoqlDdcOma+jC@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=phone-devel@vger.kernel.org \
--cc=vincent.knecht@mailoo.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®