From: Mark Brown <broonie@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: Max Filippov <jcmvbkbc@gmail.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-xtensa@linux-xtensa.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH v1] spi: xtensa-xtfpga: Fix a double put() in xtfpga_spi_remove()
Date: Tue, 13 Dec 2022 11:40:43 +0000 [thread overview]
Message-ID: <Y5hku6VFhguH2osM@sirena.org.uk> (raw)
In-Reply-To: <bdb26ba3-7276-359a-7784-6ec3e35c64de@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 589 bytes --]
On Tue, Dec 13, 2022 at 09:30:32AM +0800, Yang Yingliang wrote:
> On 2022/12/12 23:36, Mark Brown wrote:
> > On Sat, Dec 10, 2022 at 06:48:02AM -0800, Max Filippov wrote:
> > Probably worth a comment though since it is a bit of a gotcha. Ideally
> > we'd improve this in the bitbang code but that's harder.
> Ideally, spi_bitbang_stop() should undo spi_bitbang_start(). shall we move
> spi_master_put() in spi_bitbang_stop() instead of
> calling it separately in drivers?
Ideally like I say, there's issues with devm IIRC which make it more
complicated than just adding a put() there.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-12-13 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-10 11:52 Christophe JAILLET
2022-12-10 14:48 ` Max Filippov
2022-12-12 15:36 ` Mark Brown
2022-12-13 1:30 ` Yang Yingliang
2022-12-13 11:40 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5hku6VFhguH2osM@sirena.org.uk \
--to=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jcmvbkbc@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®