From: Mark Brown <broonie@kernel.org>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
kernel@pengutronix.de, Marco Felsch <m.felsch@pengutronix.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: max98088: fix dai1/2_hw_params access
Date: Tue, 13 Dec 2022 12:04:31 +0000 [thread overview]
Message-ID: <Y5hqT3KL0+XENJcj@sirena.org.uk> (raw)
In-Reply-To: <20221213095328.122309-1-r.czerwinski@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 679 bytes --]
On Tue, Dec 13, 2022 at 10:53:27AM +0100, Rouven Czerwinski wrote:
> From: Marco Felsch <m.felsch@pengutronix.de>
>
> According the reference manuals [1], [2] updating register 0x14/1c
> should only be done after #shdn bit is set to 0.
>
> [1] https://datasheets.maximintegrated.com/en/ds/MAX98089.pdf
> [2] https://datasheets.maximintegrated.com/en/ds/MAX98088.pdf
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> sound/soc/codecs/max98088.c | 8 ++++----
You've not provided a Signed-off-by for this so I can't do anything with
it, please see Documentation/process/submitting-patches.rst for details
on what this is and why it's important.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-12-13 12:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 9:53 Rouven Czerwinski
2022-12-13 9:53 ` [PATCH 2/2] ASoC: max98088: fix initial dai mute state Rouven Czerwinski
2022-12-13 12:01 ` Mark Brown
2022-12-15 9:17 ` Marco Felsch
2022-12-15 12:00 ` Mark Brown
2022-12-13 12:04 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5hqT3KL0+XENJcj@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=perex@perex.cz \
--cc=r.czerwinski@pengutronix.de \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®