From: Christoph Hellwig <hch@infradead.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Richard Weinberger <richard@nod.at>,
Matthew Wilcox <willy@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [RFC PATCH 1/2] init: move block device helpers from init/do_mounts.c
Date: Wed, 14 Dec 2022 08:44:19 -0800 [thread overview]
Message-ID: <Y5n9Yz4fNzAWczF5@infradead.org> (raw)
In-Reply-To: <Y5hz9nuq7tECYcyt@makrotopia.org>
On Tue, Dec 13, 2022 at 12:45:42PM +0000, Daniel Golle wrote:
> In init/do_mounts.c there are helper functions devt_from_partuuid,
> devt_from_partlabel and devt_from_devname. In order to make these
> functions available to other users, move them to block/bdev.c.
NAK. As pointed out many times there should be no more users.
These functions are a horrible hack forthe pre-initramfs boot
code and should not grow any additional users.
prev parent reply other threads:[~2022-12-14 16:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 12:45 Daniel Golle
2022-12-14 16:44 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5n9Yz4fNzAWczF5@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=daniel@makrotopia.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=richard@nod.at \
--cc=willy@infradead.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®