From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9228C4332F for ; Wed, 14 Dec 2022 13:03:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238320AbiLNNDM (ORCPT ); Wed, 14 Dec 2022 08:03:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238398AbiLNNCn (ORCPT ); Wed, 14 Dec 2022 08:02:43 -0500 Received: from fudo.makrotopia.org (fudo.makrotopia.org [IPv6:2a07:2ec0:3002::71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F215FCE5; Wed, 14 Dec 2022 05:02:22 -0800 (PST) Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.94.2) (envelope-from ) id 1p5ROp-0007VE-7T; Wed, 14 Dec 2022 14:02:15 +0100 Date: Wed, 14 Dec 2022 13:02:11 +0000 From: Daniel Golle To: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Jakub Kicinski , Russell King , Sean Wang , Landen Chao , DENG Qingfang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger Subject: Re: [PATCH net v2] net: dsa: mt7530: remove reduntant assignment Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Frank Wunderlich has reported a typo in the commit title, and he is right: reduntant => redundant Please either fix this while merging or wait until I'll post v3 tomorrow. On Wed, Dec 14, 2022 at 01:51:06AM +0000, Daniel Golle wrote: > Russell King correctly pointed out that the MAC_2500FD capability is > already added for port 5 (if not in RGMII mode) and port 6 (which only > supports SGMII) by mt7531_mac_port_get_caps. Remove the reduntant > setting of this capability flag which was added by a previous commit. > > Fixes: e19de30d2080 ("net: dsa: mt7530: add support for in-band link status") > Reported-by: Russell King (Oracle) > Reviewed-by: Russell King (Oracle) > Signed-off-by: Daniel Golle > --- > drivers/net/dsa/mt7530.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > index e74c6b406172..908fa89444c9 100644 > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -2919,9 +2919,6 @@ static void mt753x_phylink_get_caps(struct dsa_switch *ds, int port, > config->mac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE | > MAC_10 | MAC_100 | MAC_1000FD; > > - if ((priv->id == ID_MT7531) && mt753x_is_mac_port(port)) > - config->mac_capabilities |= MAC_2500FD; > - > /* This driver does not make use of the speed, duplex, pause or the > * advertisement in its mac_config, so it is safe to mark this driver > * as non-legacy. > > base-commit: 7e68dd7d07a28faa2e6574dd6b9dbd90cdeaae91 > -- > 2.39.0 > >