mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: hanjinke <hanjinke.666@bytedance.com>
Cc: josef@toxicpanda.com, axboe@kernel.dk, cgroups@vger.kernel.org,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [External] Re: [RFC PATCH] blk-throtl: Introduce sync queue for write ios
Date: Thu, 15 Dec 2022 06:46:54 -1000	[thread overview]
Message-ID: <Y5tPftzjXN6RcswM@slm.duckdns.org> (raw)
In-Reply-To: <1e53592f-b1f1-df85-3edb-eba4c5a5f989@bytedance.com>

Hello,

On Wed, Dec 14, 2022 at 12:02:53PM +0800, hanjinke wrote:
> Should we keep the main category of io based READ and WRITE, and within READ
> / WRITE the subcategory were SYNC and ASYNC ? This may give less intrusion
> into existing frameworks.

Ah, you haven't posted yet. So, yeah, let's do this. The code was a bit odd
looking after adding the sync queue on the side. For reads, we can just
consider everything synchrnous (or maybe treat SYNC the same way, I don't
know whether reads actually use SYNC flags tho).

Thanks.

-- 
tejun

  reply	other threads:[~2022-12-15 16:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 16:38 Jinke Han
2022-12-12 22:40 ` Tejun Heo
2022-12-13  3:55   ` [External] " hanjinke
2022-12-15 16:42     ` Tejun Heo
2022-12-14  4:02   ` hanjinke
2022-12-15 16:46     ` Tejun Heo [this message]
2022-12-16  1:36       ` hanjinke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y5tPftzjXN6RcswM@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=hanjinke.666@bytedance.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®