From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE3DEC4332F for ; Fri, 16 Dec 2022 06:36:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229678AbiLPGgO (ORCPT ); Fri, 16 Dec 2022 01:36:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229708AbiLPGgH (ORCPT ); Fri, 16 Dec 2022 01:36:07 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0823213CDC for ; Thu, 15 Dec 2022 22:36:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671172562; x=1702708562; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=vTyDp3WRHQkfKwZUmHm2YaSTJQCuH5GyeO9PrVqb4Ng=; b=InZU57EGYOXfW8U8Zwy1eWYhGK4XLdYmZL2/gdWfv9ZInmRyVE9qoOzT sp5jHzxHiZPRLA6e/yD1I4J8QUnXdRK5s4aRFZbdrnDybifCoI8ARAlmj D3KGlpodGiIFVYiaK0SBpYMGCaE8bwDPKVNWnK1Glb5ocl6wQWjpddLRn b8mOfyTgiIHKMCLRQ4N2XXYPWPu5KNrS/eHmS2E8xAcm/2Fp+ZKzVFhSQ B2u5K17OE/DyrBcFaPxil9wwI1FDGPxVYRI7cAnbMeRLKGjV2rP3QUpHd HSm6+LIlK+VRiR8fTaljYARQvTw/676KJih2YBwOo4jTyNYXsICuVnvoO A==; X-IronPort-AV: E=McAfee;i="6500,9779,10562"; a="345981625" X-IronPort-AV: E=Sophos;i="5.96,249,1665471600"; d="scan'208";a="345981625" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2022 22:36:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10562"; a="627467591" X-IronPort-AV: E=Sophos;i="5.96,249,1665471600"; d="scan'208";a="627467591" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga006.jf.intel.com with ESMTP; 15 Dec 2022 22:35:56 -0800 Received: by black.fi.intel.com (Postfix, from userid 1001) id 1FD40F7; Fri, 16 Dec 2022 08:36:26 +0200 (EET) Date: Fri, 16 Dec 2022 08:36:26 +0200 From: Mika Westerberg To: Arnd Bergmann Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Arnd Bergmann , Tokunori Ikegami , Lee Jones , Mauro Lima , Tudor Ambarus , Boris Brezillon , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: cfi: allow building spi-intel standalone Message-ID: References: <20221215163950.649791-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221215163950.649791-1-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 15, 2022 at 05:39:38PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When MTD or MTD_CFI_GEOMETRY is disabled, the spi-intel driver > fails to build, as it includes the shared CFI header: > > include/linux/mtd/cfi.h:62:2: error: #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work. [-Werror=cpp] > 62 | #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work. > > Use an #ifdef here to guard the settings so the header can be included > in all configurations. > > Fixes: e23e5a05d1fd ("mtd: spi-nor: intel-spi: Convert to SPI MEM") > Signed-off-by: Arnd Bergmann Reviewed-by: Mika Westerberg