From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] pinctrl: nomadik: fix build when DEBUG_FS is not set
Date: Thu, 29 Dec 2022 11:12:39 +0200 [thread overview]
Message-ID: <Y61aBzEjABMCXzmN@smile.fi.intel.com> (raw)
In-Reply-To: <20221229012445.16169-1-rdunlap@infradead.org>
On Wed, Dec 28, 2022 at 05:24:45PM -0800, Randy Dunlap wrote:
> Fix build when DEBUG_FS is not set/enabled by moving the #include
> directive.
>
> ../drivers/pinctrl/nomadik/pinctrl-nomadik.c: In function 'nmk_gpio_irq_print_chip':
> ../drivers/pinctrl/nomadik/pinctrl-nomadik.c:1084:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration]
> 1084 | seq_printf(p, "nmk%u-%u-%u", nmk_chip->bank,
>
> Fixes: e5530adc17a7 ("pinctrl: Clean up headers")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
I had sent
https://lore.kernel.org/linux-gpio/20221228084310.85210-1-andriy.shevchenko@linux.intel.com/T/#u
But now I see how I can amend it.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-12-29 9:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 1:24 Randy Dunlap
2022-12-29 9:12 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y61aBzEjABMCXzmN@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®