From: Herbert Xu <herbert@gondor.apana.org.au>
To: Robert Elliott <elliott@hpe.com>
Cc: davem@davemloft.net, paulmck@kernel.org, frederic@kernel.org,
quic_neeraju@quicinc.com, josh@joshtriplett.org,
linux-crypto@vger.kernel.org, rcu@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] crypto: tcrypt - suppress RCU stall warnings during speed tests
Date: Fri, 30 Dec 2022 16:39:56 +0800 [thread overview]
Message-ID: <Y66j3FkbLRLwldyb@gondor.apana.org.au> (raw)
In-Reply-To: <20221219202910.3063036-4-elliott@hpe.com>
On Mon, Dec 19, 2022 at 02:29:10PM -0600, Robert Elliott wrote:
> Suppress RCU CPU stall warnings while running speed tests.
>
> The tcrypt module is intended only for developer usage, so
> RCU stalls induced by those tests are not necessarily representative
> of real problems.
>
> Speed tests need to disable interrupts or preemption to get results
> that are not distorted by such interruptions. This triggers more
> RCU stalls than normal invocations of the crypto functions.
Where do we disable interrupts? That would seem to break the
use of jiffies since it won't get updated anymore.
Which particular test is still triggering the RCU warnings after
fixing the hash problems that you've already identified?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2022-12-30 8:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 20:29 [PATCH 0/3] crypto/rcu: suppress unnecessary CPU stall warnings Robert Elliott
2022-12-19 20:29 ` [PATCH 1/3] rcu: genericize RCU stall suppression functions Robert Elliott
2022-12-21 18:56 ` Paul E. McKenney
2023-01-10 6:07 ` Joel Fernandes
2023-01-10 6:12 ` Joel Fernandes
2022-12-19 20:29 ` [PATCH 2/3] rcu: print first CPU on expedited stall line Robert Elliott
2022-12-21 19:02 ` Paul E. McKenney
2022-12-19 20:29 ` [PATCH 3/3] crypto: tcrypt - suppress RCU stall warnings during speed tests Robert Elliott
2022-12-30 8:39 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y66j3FkbLRLwldyb@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=elliott@hpe.com \
--cc=frederic@kernel.org \
--cc=josh@joshtriplett.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=quic_neeraju@quicinc.com \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®