From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] gpiolib: of: remove of_gpio_count()
Date: Tue, 20 Dec 2022 15:51:43 +0200 [thread overview]
Message-ID: <Y6G97zJwHaW+Kmo0@smile.fi.intel.com> (raw)
In-Reply-To: <20221219192016.1396950-1-dmitry.torokhov@gmail.com>
On Mon, Dec 19, 2022 at 11:20:12AM -0800, Dmitry Torokhov wrote:
> There are no more users of of_gpio_count() in the mainline kernel,
> remove it.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>
> After 6.2-rc1 there should be no more users of the APIs mentioned in
> this series.
I believe you probably want to have this patch applied immediately to the GPIO
subsystem after v6.2-rc1 to avoid new users.
> include/linux/of_gpio.h | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/include/linux/of_gpio.h b/include/linux/of_gpio.h
> index 6db627257a7b..39f16a960565 100644
> --- a/include/linux/of_gpio.h
> +++ b/include/linux/of_gpio.h
> @@ -105,17 +105,6 @@ static inline int of_gpio_named_count(const struct device_node *np,
> return of_count_phandle_with_args(np, propname, "#gpio-cells");
> }
>
> -/**
> - * of_gpio_count() - Count GPIOs for a device
> - * @np: device node to count GPIOs for
> - *
> - * Same as of_gpio_named_count, but hard coded to use the 'gpios' property
> - */
> -static inline int of_gpio_count(const struct device_node *np)
> -{
> - return of_gpio_named_count(np, "gpios");
> -}
> -
> static inline int of_get_gpio_flags(const struct device_node *np, int index,
> enum of_gpio_flags *flags)
> {
> --
> 2.39.0.314.g84b9a713c41-goog
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-12-20 13:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 19:20 Dmitry Torokhov
2022-12-19 19:20 ` [PATCH 2/5] gpiolib: of: stop exporting of_gpio_named_count() Dmitry Torokhov
2022-12-20 13:50 ` Andy Shevchenko
2022-12-20 18:27 ` Dmitry Torokhov
2022-12-20 19:15 ` Andy Shevchenko
2022-12-19 19:20 ` [PATCH 3/5] gpiolib: of: remove obsolete comment for of_gpio_get_count() Dmitry Torokhov
2022-12-20 13:52 ` Andy Shevchenko
2023-01-09 13:07 ` Linus Walleij
2022-12-19 19:20 ` [PATCH 4/5] gpiolib: of: remove of_get_gpio[_flags]() and of_get_named_gpio_flags() Dmitry Torokhov
2022-12-20 13:58 ` Andy Shevchenko
2022-12-20 18:29 ` Dmitry Torokhov
2022-12-20 19:16 ` Andy Shevchenko
2022-12-19 19:20 ` [PATCH 5/5] gpiolib: of: remove [devm_]gpiod_get_from_of_node() APIs Dmitry Torokhov
2022-12-20 14:01 ` Andy Shevchenko
2022-12-20 18:30 ` Dmitry Torokhov
2022-12-20 13:51 ` Andy Shevchenko [this message]
2022-12-20 18:33 ` [PATCH 1/5] gpiolib: of: remove of_gpio_count() Dmitry Torokhov
2022-12-30 15:55 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6G97zJwHaW+Kmo0@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®