From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86CD8C4167B for ; Wed, 21 Dec 2022 20:27:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234844AbiLUU10 (ORCPT ); Wed, 21 Dec 2022 15:27:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229844AbiLUU1W (ORCPT ); Wed, 21 Dec 2022 15:27:22 -0500 Received: from netrider.rowland.org (netrider.rowland.org [192.131.102.5]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 909EB24F23 for ; Wed, 21 Dec 2022 12:27:21 -0800 (PST) Received: (qmail 100059 invoked by uid 1000); 21 Dec 2022 15:27:20 -0500 Date: Wed, 21 Dec 2022 15:27:20 -0500 From: Alan Stern To: Ricardo Ribalda Cc: Greg Kroah-Hartman , Bagas Sanjaya , Christoph Hellwig , linux-kernel@vger.kernel.org, Laurent Pinchart , Randy Dunlap , linux-usb@vger.kernel.org Subject: Re: [PATCH v4] USB: Improve usb_fill_* documentation Message-ID: References: <20221220-usb-dmadoc-v4-0-74a045bf14f4@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221220-usb-dmadoc-v4-0-74a045bf14f4@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 21, 2022 at 08:34:51PM +0100, Ricardo Ribalda wrote: > Document the transfer buffer requirement. That is, the buffer must be > DMAble - otherwise data corruption might occur. > > Acked-by: Randy Dunlap > Reviewed-by: Laurent Pinchart > Signed-off-by: Ricardo Ribalda > --- > USB: Improve usb_fill_* documentation > > After trying to "cleanup" the uvc code, I was patiently explained about > the requirements of the urb transfer buffers. > > Lets make this explicit, so other developers do not make the same mistake. > > To: Bagas Sanjaya > To: Randy Dunlap > To: Alan Stern > To: Christoph Hellwig > To: Laurent Pinchart > To: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- Acked-by: Alan Stern