mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: James Clark <james.clark@arm.com>
Cc: linux-perf-users@vger.kernel.org, tanmay@marvell.com,
	sgoutham@marvell.com, gcherian@marvell.com, lcherian@marvell.com,
	bbhushan2@marvell.com,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>,
	John Garry <john.g.garry@oracle.com>,
	Will Deacon <will@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/7] perf: Use perf_pmu__open_file() and perf_pmu__scan_file()
Date: Fri, 23 Dec 2022 11:59:51 +0800	[thread overview]
Message-ID: <Y6Unt0E4qM5oqE9+@leoy-yangtze.lan> (raw)
In-Reply-To: <Y6UkUQ9dcQQwvRpz@leoy-yangtze.lan>

On Fri, Dec 23, 2022 at 11:45:21AM +0800, Leo Yan wrote:

[...]

> > @@ -103,8 +103,9 @@ static int test__perf_evsel__roundtrip_name_test(struct test_suite *test __maybe
> >  						 int subtest __maybe_unused)
> >  {
> >  	int err = 0, ret = 0;
> > +	char cpu_atom[] = "cpu_atom";
> >  
> > -	if (perf_pmu__has_hybrid() && perf_pmu__hybrid_mounted("cpu_atom"))
> > +	if (perf_pmu__has_hybrid() && perf_pmu__hybrid_mounted(cpu_atom))
> 
> After change the parameter 'name' to non const type in function
> perf_pmu__hybrid_mounted(), at here we still can pass string "cpu_atom"
> without warning, right?  If so, we don't need to define a local
> variable 'cpu_atom'.

Correct for above statement, I did experiment and confirmed building
failure after change the parameter to non const type and directly pass
string "cpu_atom":

tests/evsel-roundtrip-name.c: In function ‘test__perf_evsel__roundtrip_name_test’:
tests/evsel-roundtrip-name.c:108:64: error: passing argument 1 of ‘perf_pmu__hybrid_mounted’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
  108 |         if (perf_pmu__has_hybrid() && perf_pmu__hybrid_mounted("cpu_atom"))
      |                                                                ^~~~~~~~~~

But I still suggest we can keep const type for the parameter for
perf_pmu__hybrid_mounted(), this is more friendly for its callers
without define local strings.

Thanks,
Leo

  reply	other threads:[~2022-12-23  4:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-22 16:03 [PATCH v2 0/7] perf cs_etm: Basic support for virtual/kernel timestamps James Clark
2022-12-22 16:03 ` [PATCH v2 1/7] perf: Remove duplication around EVENT_SOURCE_DEVICE_PATH James Clark
2022-12-23  2:39   ` Leo Yan
2023-01-03 16:21     ` James Clark
2022-12-22 16:03 ` [PATCH v2 2/7] perf: Use perf_pmu__open_file() and perf_pmu__scan_file() James Clark
2022-12-23  3:45   ` Leo Yan
2022-12-23  3:59     ` Leo Yan [this message]
2023-01-03 16:21     ` James Clark
2022-12-22 16:03 ` [PATCH v2 3/7] perf: Remove remaining duplication of bus/event_source/devices/ James Clark
2022-12-23  6:10   ` Leo Yan
2022-12-22 16:03 ` [PATCH v2 4/7] perf pmu: Add function to check if a pmu file exists James Clark
2022-12-23  6:26   ` Leo Yan
2023-01-03 16:22     ` James Clark
2022-12-22 16:03 ` [PATCH v2 5/7] perf cs_etm: Keep separate symbols for ETMv4 and ETE parameters James Clark
2022-12-23  9:54   ` Mike Leach
2022-12-22 16:03 ` [PATCH v2 6/7] perf cs_etm: Record ts_source in AUXTRACE_INFO for ETMv4 and ETE James Clark
2022-12-23  9:28   ` Mike Leach
2023-01-03 11:49     ` James Clark
2023-01-03 15:15       ` Suzuki K Poulose
2022-12-22 16:03 ` [PATCH v2 7/7] perf cs_etm: Set the time field in the synthetic samples James Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y6Unt0E4qM5oqE9+@leoy-yangtze.lan \
    --to=leo.yan@linaro.org \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bbhushan2@marvell.com \
    --cc=coresight@lists.linaro.org \
    --cc=gcherian@marvell.com \
    --cc=james.clark@arm.com \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=lcherian@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sgoutham@marvell.com \
    --cc=suzuki.poulose@arm.com \
    --cc=tanmay@marvell.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®