From: Borislav Petkov <bp@alien8.de>
To: Ashok Raj <ashok.raj@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, X86-kernel <x86@kernel.org>,
LKML Mailing List <linux-kernel@vger.kernel.org>,
Dave Hansen <dave.hansen@intel.com>,
Tony Luck <tony.luck@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH v2 1/6] x86/microcode/core: Move microcode_check() to cpu/microcode/core.c
Date: Tue, 27 Dec 2022 20:50:25 +0100 [thread overview]
Message-ID: <Y6tMgcU2aGbx/6yt@zn.tnic> (raw)
In-Reply-To: <20221227192340.8358-2-ashok.raj@intel.com>
On Tue, Dec 27, 2022 at 11:23:35AM -0800, Ashok Raj wrote:
> microcode_check() is only called from microcode/core.c. Move it and make
> it static to prepare for upcoming fix for false negative when checking CPU
> features after a microcode update. Also move get_cpu_cap() to processor.h
> for general use outside of arch/x86/kernel/cpu/cpu.h
I thought we agreed not to do this:
https://lore.kernel.org/r/Y44bbZMMf8I6Lzl/@zn.tnic
Or was this a misunderstanding?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-12-27 19:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 19:23 [PATCH v2 0/6] Some fixes and cleanups for microcode Ashok Raj
2022-12-27 19:23 ` [PATCH v2 1/6] x86/microcode/core: Move microcode_check() to cpu/microcode/core.c Ashok Raj
2022-12-27 19:50 ` Borislav Petkov [this message]
2022-12-27 19:59 ` Ashok Raj
2022-12-27 21:01 ` [PATCH v3 1/2] x86/microcode: Add a parameter to microcode_check() to store CPU capabilities Ashok Raj
2022-12-27 21:01 ` [PATCH v3 2/2] x86/microcode/core: Take a snapshot before and after applying microcode Ashok Raj
2022-12-28 18:36 ` Ashok Raj
2022-12-27 19:23 ` [PATCH v2 2/6] " Ashok Raj
2022-12-27 19:23 ` [PATCH v2 3/6] x86/microcode: Display revisions only when update is successful Ashok Raj
2022-12-27 19:23 ` [PATCH v2 4/6] x86/microcode/intel: Use a plain revision argument for print_ucode_rev() Ashok Raj
2022-12-27 19:23 ` [PATCH v2 5/6] x86/microcode/intel: Print old and new rev during early boot Ashok Raj
2022-12-27 19:23 ` [PATCH v2 6/6] x86/microcode/intel: Print when early microcode loading fails Ashok Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6tMgcU2aGbx/6yt@zn.tnic \
--to=bp@alien8.de \
--cc=alison.schofield@intel.com \
--cc=ashok.raj@intel.com \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®