From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1978C46467 for ; Wed, 28 Dec 2022 08:53:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229912AbiL1IxI (ORCPT ); Wed, 28 Dec 2022 03:53:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229707AbiL1IxF (ORCPT ); Wed, 28 Dec 2022 03:53:05 -0500 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0BF418B; Wed, 28 Dec 2022 00:53:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672217584; x=1703753584; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8fUF24/ihBlgYQOdGQDE6pDDEjiexMimLn7EKulDOvg=; b=Qj9KPZlg09O6+3mAyW+yo0skvxYIpV71rxgkh7mt+GdU9qwTWII7LCv1 WBfsEen6U3Zdk7uVhewZ4Tt6kGjpcMXhxW+Ik6Zf0eF+8VWlLIx98buPu re1tygmoFLPZtvPrWOi8kUp2uCOhCN4nx6+bWEsgZ9tU8a1SSfCEmsmg8 NsVlsJnrEup0eYoX0NB2oVgnW8fOnafnl6Fcey8eZ8YBfiukzcdbiUGZu oO/9Y/BFCKoWAbo8HjpKK9DXcLXcS7cMkBwRKslVeAQSWo7bDWw2U5/QG LMi3XvwutGPavH/5fIN5clBVs/kLYHNscIhATQIyycT6Wm55cwxPfaDjT g==; X-IronPort-AV: E=McAfee;i="6500,9779,10573"; a="322815948" X-IronPort-AV: E=Sophos;i="5.96,280,1665471600"; d="scan'208";a="322815948" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2022 00:53:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10573"; a="646672225" X-IronPort-AV: E=Sophos;i="5.96,280,1665471600"; d="scan'208";a="646672225" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 28 Dec 2022 00:53:01 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pASBH-000V45-2R; Wed, 28 Dec 2022 10:52:59 +0200 Date: Wed, 28 Dec 2022 10:52:59 +0200 From: Andy Shevchenko To: Arnd Bergmann Cc: Linus Walleij , Arnd Bergmann , Miaoqian Lin , Marc Zyngier , Lukas Bulwahn , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: nomadik: include linux/seq_file.h Message-ID: References: <20221215170103.2349282-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 15, 2022 at 07:16:54PM +0200, Andy Shevchenko wrote: > On Thu, Dec 15, 2022 at 06:00:57PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > In some randconfig builds, the missing #include causes a > > build failure: > > > > drivers/pinctrl/nomadik/pinctrl-nomadik.c: In function 'nmk_gpio_irq_print_chip': > > drivers/pinctrl/nomadik/pinctrl-nomadik.c:1084:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration] > > 1084 | seq_printf(p, "nmk%u-%u-%u", nmk_chip->bank, > > | ^~~~~~~~~~ > > | bstr_printf > > Hmm... Strange that I have not noticed this from CIs. > Nevertheless, I have a patch that adds more missing > headers to this driver. I have planned to send it > after v6.2-rc1. > > I'm fine if this goes first. Up to Linus. FYI: I have just sent my version https://lore.kernel.org/r/20221228084310.85210-1-andriy.shevchenko@linux.intel.com -- With Best Regards, Andy Shevchenko