From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hanna Hawa <hhhawa@amazon.com>
Cc: wsa@kernel.org, linus.walleij@linaro.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, dwmw@amazon.co.uk, benh@amazon.com,
ronenk@amazon.com, talel@amazon.com, jonnyc@amazon.com,
hanochu@amazon.com, farbere@amazon.com, itamark@amazon.com
Subject: Re: [PATCH v4 2/2] i2c: Set i2c pinctrl recovery info from it's device pinctrl
Date: Wed, 28 Dec 2022 17:09:13 +0200 [thread overview]
Message-ID: <Y6xcGWK7ghrQIjL/@smile.fi.intel.com> (raw)
In-Reply-To: <20221221205116.73941-3-hhhawa@amazon.com>
On Wed, Dec 21, 2022 at 08:51:16PM +0000, Hanna Hawa wrote:
> Currently the i2c subsystem rely on the controller device tree to
> initialize the pinctrl recovery information, part of the drivers does
> not set this field (rinfo->pinctrl), for example i2c designware driver.
DesignWare
> The pins information is saved part of the device structure before probe
> and it's done on pinctrl_bind_pins().
>
> Make the i2c init recovery to get the device pins if it's not
> initialized by the driver from the device pins.
...
> - struct pinctrl *p = bri->pinctrl;
> + struct pinctrl *p;
> +
> + bri->pinctrl = bri->pinctrl ?: dev_pinctrl(dev->parent);
> + p = bri->pinctrl;
What about
struct pinctrl *p = bri->pinctrl ?: dev_pinctrl(dev->parent);
bri->pinctrl = p;
?
Seems like one line of code less.
Either way,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-12-28 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 20:51 [PATCH v4 0/2] " Hanna Hawa
2022-12-21 20:51 ` [PATCH v4 1/2] pinctrl: Add an API to get the pinctrl pins if initialized Hanna Hawa
2022-12-28 15:05 ` Andy Shevchenko
2022-12-21 20:51 ` [PATCH v4 2/2] i2c: Set i2c pinctrl recovery info from it's device pinctrl Hanna Hawa
2022-12-28 15:09 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6xcGWK7ghrQIjL/@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=benh@amazon.com \
--cc=dwmw@amazon.co.uk \
--cc=farbere@amazon.com \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=itamark@amazon.com \
--cc=jonnyc@amazon.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®