From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4C1CC3DA7A for ; Thu, 29 Dec 2022 01:32:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232066AbiL2Bcc (ORCPT ); Wed, 28 Dec 2022 20:32:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229716AbiL2Bca (ORCPT ); Wed, 28 Dec 2022 20:32:30 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 922B010B56; Wed, 28 Dec 2022 17:32:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=wFEk/iA1Bc8CnhqgYSVgaN6BA6Rzt62Yam9vSIo8sOo=; b=hr HVMsYaNFJPBAuXoUwdUWyibrAQ3REPBAUF4rnqyNCD+xF8dFOQkRgUaaXJx6/VZHR0UOfSbIBX1D6 lUeH7IOfip9xQeN2cs5B8WSHy0bVup+/W0OkFqQ4BQxgbSfB0bVXtZknAi3gn7eOwEsRWQ87OQp3b TyeE83eTKjLo2nw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pAhmQ-000g6A-DP; Thu, 29 Dec 2022 02:32:22 +0100 Date: Thu, 29 Dec 2022 02:32:22 +0100 From: Andrew Lunn To: =?utf-8?Q?Micha=C5=82?= Grzelak Cc: linux-kernel@vger.kernel.org, sebastian.hesselbarth@gmail.com, gregory.clement@bootlin.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, mw@semihalf.com, upstream@semihalf.com, mchl.grzlk@gmail.com Subject: Re: [PATCH v2] ARM: dts: dove.dtsi: Move ethphy to fix schema error Message-ID: References: <20221228200234.86391-1-mig@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221228200234.86391-1-mig@semihalf.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 28, 2022 at 09:02:34PM +0100, Michał Grzelak wrote: > Running 'make dtbs_check' with schema in net/marvell,orion-mdio.yaml > gives the following warnings: > mdio-bus@72004: Unevaluated properties are not allowed > ('ethernet-phy' was unexpected) > arch/arm/boot/dts/dove-cubox.dtb > arch/arm/boot/dts/dove-cubox-es.dtb > arch/arm/boot/dts/dove-d2plug.dtb > arch/arm/boot/dts/dove-d2plug.dtb > arch/arm/boot/dts/dove-dove-db.dtb > arch/arm/boot/dts/dove-d3plug.dtb > arch/arm/boot/dts/dove-sbc-a510.dtb > Fix them by removing empty ethphy subnode from dove.dtsi and describe > PHY on the relevant board .dts files level. I don't think your description is correct. What i think is causing the problem is that the ethphy subnode in dove.dtsi does not have an @X. By moving it into the .dts file, you can then give it the correct @1, or @3, which makes the linter happy. The kernel itself does not care about this, it is an example of the linter being much more strict than the kernel. If you agree with me, please update the description. Andrew