From: Chen Yu <yu.c.chen@intel.com>
To: Yuanhan Zhang <zyhtheonly@gmail.com>
Cc: <mingo@redhat.com>, <peterz@infradead.org>,
<juri.lelli@redhat.com>, <vincent.guittot@linaro.org>,
<linux-kernel@vger.kernel.org>, <pmladek@suse.com>,
<zyhtheonly@yeah.net>, <zwp10758@gmail.com>,
<tiozhang@didiglobal.com>
Subject: Re: [PATCH] sched: print parent comm in sched_show_task()
Date: Thu, 12 Jan 2023 16:40:36 +0800 [thread overview]
Message-ID: <Y7/HhF2OQQc70Dfv@chenyu5-mobl1> (raw)
In-Reply-To: <CAEQmJ=gZJL6K1yUPq0hHy5D7Rc6g=5Ri72V_kE=xfqR6gJedWg@mail.gmail.com>
Hi,
On 2023-01-10 at 17:35:34 +0800, Yuanhan Zhang wrote:
> Hi Petr and Chen,
> Thanks for your emails! Petr's suggestions sure make a lot of sense.
> Please review the following implementation, it would print a new line like:
> " parent:kthreadd ppid:2 "
> after the origin line.
>
> ---
>
> kernel/sched/core.c | 15 ++++++++-------
>
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
>
> index cb2aa2b54c7a..86ee90404ddb 100644
>
> --- a/kernel/sched/core.c
>
> +++ b/kernel/sched/core.c
>
> @@ -8853,7 +8853,7 @@ SYSCALL_DEFINE2(sched_rr_get_interval_time32, pid_t,
> pid,
>
> void sched_show_task(struct task_struct *p)
>
> {
>
> unsigned long free = 0;
>
> - int ppid;
>
> + struct task_struct *parent;
>
Above line could be moved inside: if (pid_alive(p)).
And the format of this patch seems to be broken, please resend after fixing the issues
reported by scripts/checkpatch.pl
thanks,
Chenyu
next prev parent reply other threads:[~2023-01-12 8:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 16:14 Tio Zhang
2022-12-29 4:25 ` Chen Yu
[not found] ` <CAEQmJ=gcCx1hMf7HicE5OFeUstipdtr=3JkF1JxLuP-CrG++Pw@mail.gmail.com>
2023-01-04 13:40 ` Petr Mladek
2023-01-06 9:51 ` Chen Yu
[not found] ` <CAEQmJ=gZJL6K1yUPq0hHy5D7Rc6g=5Ri72V_kE=xfqR6gJedWg@mail.gmail.com>
2023-01-12 8:40 ` Chen Yu [this message]
2023-01-04 13:24 ` Petr Mladek
2023-01-13 10:54 Tio Zhang
2023-01-16 9:26 ` Chen Yu
2023-01-17 8:33 ` 张元瀚 Tio Zhang
2023-01-18 11:06 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7/HhF2OQQc70Dfv@chenyu5-mobl1 \
--to=yu.c.chen@intel.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=tiozhang@didiglobal.com \
--cc=vincent.guittot@linaro.org \
--cc=zwp10758@gmail.com \
--cc=zyhtheonly@gmail.com \
--cc=zyhtheonly@yeah.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®