From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 862C1C54EBC for ; Tue, 10 Jan 2023 11:36:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231419AbjAJLgG (ORCPT ); Tue, 10 Jan 2023 06:36:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237624AbjAJLf6 (ORCPT ); Tue, 10 Jan 2023 06:35:58 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 745F5DF64 for ; Tue, 10 Jan 2023 03:35:56 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id l26so8545500wme.5 for ; Tue, 10 Jan 2023 03:35:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=ED6k4JMWZP+JYHhb7ScjuYbNhfGq5URyyjoXmYShkJU=; b=KUzDn3S7lnFnuDGV2nlVhXXJuEqbzOIlo+cSfFXZ9wFCaKyxr7v1Vv6LIuH9Sze4Kt tQteoiXPBLKXS4ERzNS72hNZSSlZgiPjj6f+/n49mA/FKumuNlXZGHujQ9a/uONP3plp pat4GJ9EWEpSd11+2g1OsJ0XVFYldmCRv2XOBMRbedDoCLOE3HsmBZDV3PTg5SXp/EUT lj0ig9p87VX68LmEpr8exVe38cY55sb/kOpUT21bB9xMpXzEqU9xw4sjbGRczfh9gpOL p7WfKuY8VSBKEGmCvKNfVC79QHgw0IomIP9pUGYJwayy3B6U4gaoCzkngkjhmVmrAqeH BIgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ED6k4JMWZP+JYHhb7ScjuYbNhfGq5URyyjoXmYShkJU=; b=VTykclzeU9JRYVKdbYbkRQ4gOo65+oV3tSkPXfILDRWoLYj3Xa8sxNbdTHIpQnwO0B gHXcxTj7UDp6EKKTPf7/7bN4ztw8Ir5InDQjGWmcylCQOLeQncRbOW0ooUd+ZPQUEgSc BQeLOVYqfCUczqdF/CjzjDhfVIux8jSH04+DELRrnw8V8AKigljYjLGIM0Jy5GF5UtwG h04NyRxoOeDlEnM/O3UFHJUcAMGjx8cs5ZBlniIVLIcUxbt/Lw3SL6H6I1YhIr85j3Qp 45OfOzm6VwF7DLMJUsyr1HhWrsM47VGEly4X3V/yipLBO3ekCMPHKZUh0zJRAFZgOB3B WD6Q== X-Gm-Message-State: AFqh2kr/pmEy9wLd+WYIZw2+k8b0oo8x2PxuLHd1r8ZC7IF9D3iVf8eE RMojjRijqFrNB6qLq9JQm9I= X-Google-Smtp-Source: AMrXdXtA/GUM0qJrNULkhQnQ23rk25GMU+H7HHMVMJEpLBI63FicwNiWgNqTJLla20mTGIGMlnfTRA== X-Received: by 2002:a05:600c:3c93:b0:3d9:ed30:79d with SMTP id bg19-20020a05600c3c9300b003d9ed30079dmr6364540wmb.18.1673350555074; Tue, 10 Jan 2023 03:35:55 -0800 (PST) Received: from gmail.com (1F2EF2EB.nat.pool.telekom.hu. [31.46.242.235]) by smtp.gmail.com with ESMTPSA id p9-20020a05600c1d8900b003d9d23ab449sm15081256wms.29.2023.01.10.03.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 03:35:52 -0800 (PST) Sender: Ingo Molnar Date: Tue, 10 Jan 2023 12:35:50 +0100 From: Ingo Molnar To: Peter Zijlstra Cc: x86@kernel.org, linux-kernel@vger.kernel.org, "H. Peter Anvin" , Borislav Petkov Subject: Re: x86/boot: Avoid using Intel mnemonics in AT&T syntax asm Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Zijlstra wrote: > > With 'GNU assembler (GNU Binutils for Debian) 2.39.90.20221231' the > build now reports: > > arch/x86/realmode/rm/../../boot/bioscall.S: Assembler messages: > arch/x86/realmode/rm/../../boot/bioscall.S:35: Warning: found `movsd'; assuming `movsl' was meant > arch/x86/realmode/rm/../../boot/bioscall.S:70: Warning: found `movsd'; assuming `movsl' was meant > > arch/x86/boot/bioscall.S: Assembler messages: > arch/x86/boot/bioscall.S:35: Warning: found `movsd'; assuming `movsl' was meant > arch/x86/boot/bioscall.S:70: Warning: found `movsd'; assuming `movsl' was meant > > Which is due to: > > PR gas/29525 > > Note that with the dropped CMPSD and MOVSD Intel Syntax string insn > templates taking operands, mixed IsString/non-IsString template groups > (with memory operands) cannot occur anymore. With that > maybe_adjust_templates() becomes unnecessary (and is hence being > removed). > > More details: https://sourceware.org/bugzilla/show_bug.cgi?id=29525 > > Fixes: 7a734e7dd93b ("x86, setup: "glove box" BIOS calls -- infrastructure") > Signed-off-by: Peter Zijlstra (Intel) > --- > arch/x86/boot/bioscall.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/arch/x86/boot/bioscall.S > +++ b/arch/x86/boot/bioscall.S > @@ -32,7 +32,7 @@ > movw %dx, %si > movw %sp, %di > movw $11, %cx > - rep; movsd > + rep; movsl > > /* Pop full state from the stack */ > popal > @@ -67,7 +67,7 @@ > jz 4f > movw %sp, %si > movw $11, %cx > - rep; movsd > + rep; movsl > 4: addw $44, %sp So I think the GAS change to introduce this warning was probably unnecessary - these instructions weren't really causing any trouble and the syntax was basically a legacy thing that shouldn't be touched - but I guess that argument is water down the bridge now: Reviewed-by: Ingo Molnar Thanks, Ingo