From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B274C54EBE for ; Tue, 10 Jan 2023 11:36:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229577AbjAJLgq (ORCPT ); Tue, 10 Jan 2023 06:36:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237985AbjAJLgh (ORCPT ); Tue, 10 Jan 2023 06:36:37 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BF4C5131F for ; Tue, 10 Jan 2023 03:36:34 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 75F851EC01B7; Tue, 10 Jan 2023 12:36:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1673350592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=FydzkbUqhNLO3+ARGz/dT0rUfRDNk8dNGvb0boW3dFU=; b=nkp/JZRPSfmTBMc8q7QgHCsa3PxwacM5F15SXtSnJrRHxp6Owdc415aKgnXPp3t3Snzwb3 X5osQHdWvi2S0DrCk6Nnl1rIFarMBD55Bs7xFPvt+1yn+wLqMCU5J/DjxttCEtd1lkOmGu Yy1dnXGjY3zP9uaDKxo3SopLMvNMl4A= Date: Tue, 10 Jan 2023 12:36:32 +0100 From: Borislav Petkov To: Peter Zijlstra Cc: x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: x86/boot: Avoid using Intel mnemonics in AT&T syntax asm Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 10, 2023 at 12:15:40PM +0100, Peter Zijlstra wrote: > > With 'GNU assembler (GNU Binutils for Debian) 2.39.90.20221231' the > build now reports: > > arch/x86/realmode/rm/../../boot/bioscall.S: Assembler messages: > arch/x86/realmode/rm/../../boot/bioscall.S:35: Warning: found `movsd'; assuming `movsl' was meant > arch/x86/realmode/rm/../../boot/bioscall.S:70: Warning: found `movsd'; assuming `movsl' was meant > > arch/x86/boot/bioscall.S: Assembler messages: > arch/x86/boot/bioscall.S:35: Warning: found `movsd'; assuming `movsl' was meant > arch/x86/boot/bioscall.S:70: Warning: found `movsd'; assuming `movsl' was meant > > Which is due to: > > PR gas/29525 > > Note that with the dropped CMPSD and MOVSD Intel Syntax string insn > templates taking operands, mixed IsString/non-IsString template groups > (with memory operands) cannot occur anymore. With that > maybe_adjust_templates() becomes unnecessary (and is hence being > removed). > > More details: https://sourceware.org/bugzilla/show_bug.cgi?id=29525 Right, I'm being told the particular problem here is is that the 'd' suffix is "conflicting" in the sense that you can have SSE mnemonics like movsD %xmm... and the same thing also for string ops (which is the case here) so apparently the agreement in binutils land is to use the always accepted suffixes 'l' or 'q' and phase out 'd' slowly... Which is basically what the PR text says above but more understanable. :-) Might wanna add that to the commit message. > Fixes: 7a734e7dd93b ("x86, setup: "glove box" BIOS calls -- infrastructure") > Signed-off-by: Peter Zijlstra (Intel) > --- > arch/x86/boot/bioscall.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) In any case Acked-by: Borislav Petkov (AMD) Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette