From: Alan Stern <stern@rowland.harvard.edu>
To: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Cc: "Jó Ágila Bitsch" <jgilab@gmail.com>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v3] usb: gadget: add WebUSB landing page support
Date: Tue, 10 Jan 2023 11:09:05 -0500 [thread overview]
Message-ID: <Y72Noc+gTlXIGE78@rowland.harvard.edu> (raw)
In-Reply-To: <e1c43612-3f36-8213-c515-9fac11b184ff@collabora.com>
On Tue, Jan 10, 2023 at 02:28:55PM +0100, Andrzej Pietrasiewicz wrote:
> Hi Jó,
>
> W dniu 10.01.2023 o 00:19, Jó Ágila Bitsch pisze:
> > > > + buf[1] = /* WEBUSB_URL*/ 3;
> > >
> > > Why not #define WEBUSB_URL?
> >
> > in a previous iteration, I had that exact #define in place, right
> > above. However, another reviewer found it pointless. Maybe I should
> > instead put the define into include/uapi/linux/usb/ch9.h
> >
>
> Hmm. ch9.h had been called ch9.h for a reason. It corresponded to Chapter 9 of
> the USB spec. Adding to it something that by design is outside the spec might
> not be what we want. But I don't know.
It wouldn't hurt to create a new file: include/uapi/linux/usb/webusb.h.
Alan Stern
next prev parent reply other threads:[~2023-01-10 16:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 16:58 [PATCH] usb: gadget: add WebUSB support Jó Ágila Bitsch
2022-12-30 17:51 ` Christophe JAILLET
2022-12-30 19:37 ` Jó Ágila Bitsch
2022-12-30 20:11 ` [PATCH v1] " Jó Ágila Bitsch
2022-12-31 19:47 ` Alan Stern
2022-12-31 20:26 ` Jó Ágila Bitsch
2023-01-01 16:21 ` Alan Stern
2023-01-01 16:59 ` [PATCH v3] usb: gadget: add WebUSB landing page support Jó Ágila Bitsch
2023-01-09 17:49 ` Andrzej Pietrasiewicz
2023-01-09 23:19 ` Jó Ágila Bitsch
2023-01-10 13:28 ` Andrzej Pietrasiewicz
2023-01-10 16:09 ` Alan Stern [this message]
2023-01-13 0:53 ` [PATCH v4] " Jó Ágila Bitsch
2023-01-10 23:15 ` [PATCH v3] " Jó Ágila Bitsch
2023-01-01 11:40 ` [PATCH v2] usb: gadget: add WebUSB support Jó Ágila Bitsch
2023-01-01 15:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y72Noc+gTlXIGE78@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=andrzej.p@collabora.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=jgilab@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®