From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFFDAC5479D for ; Wed, 11 Jan 2023 13:05:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231536AbjAKNFO (ORCPT ); Wed, 11 Jan 2023 08:05:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233889AbjAKNE4 (ORCPT ); Wed, 11 Jan 2023 08:04:56 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C414A1A3A4 for ; Wed, 11 Jan 2023 05:04:55 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1F147B81BDF for ; Wed, 11 Jan 2023 13:04:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23445C433EF; Wed, 11 Jan 2023 13:04:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673442292; bh=2nPmER6dDDP3Hd+5xChKX8yrvFkX1YePh8FS7yjYDLA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dKFxMjoptpafvuFWZQ2oDf050RWxoHah5j0+EZpjgf2u96fn2u8S2EUo0UrIQHA/R U+rb/Z97ZG48APof4QCjVsHmJkQemShjQK6b5+eDMdX32gx5KtK0DUFg2j1mTpvOz8 3luuSSHhceVzg3pNX3rI+jA7RRobBDTjDF+l13iUtSYrF8SEUHtydTK++b5mE3wCpr d7vvUUMjhyhEcQtQnlclOjs4ZJxKi1ezg7fk4kPg/aZ9+Y7zSESv2VCYa3vCi7nUA1 OgZQLEcp5bCRHknvWpkegEMScGotvx677bvbZbeQ/8fOOgYbkdkiomBqB/5jobpWFc bvLr7ywB9sy3A== Date: Wed, 11 Jan 2023 13:04:46 +0000 From: Mark Brown To: Vijendar Mukunda Cc: vkoul@kernel.org, alsa-devel@alsa-project.org, Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com, Mario.Limonciello@amd.com, Mastan.Katragadda@amd.com, arungopal.kondaveeti@amd.com, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Syed Saba Kareem , open list Subject: Re: [PATCH 08/19] ASoC: amd: ps: add soundwire dma driver dma ops Message-ID: References: <20230111090222.2016499-1-Vijendar.Mukunda@amd.com> <20230111090222.2016499-9-Vijendar.Mukunda@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ag3m81g3IJWqkKTr" Content-Disposition: inline In-Reply-To: <20230111090222.2016499-9-Vijendar.Mukunda@amd.com> X-Cookie: Life is not for everyone. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ag3m81g3IJWqkKTr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 11, 2023 at 02:32:11PM +0530, Vijendar Mukunda wrote: > +static int acp63_sdw_dma_start(struct snd_pcm_substream *stream) > +{ > + struct sdw_stream_instance *sdw_ins; > + struct snd_soc_pcm_runtime *prtd; > + u32 stream_id; > + u32 sdw_dma_reg; > + u32 sdw_dma_en_stat_reg; > + u32 sdw_dma_stat; > + u32 val; > + int timeout = 0; > + > + sdw_ins = stream->runtime->private_data; > + prtd = stream->private_data; > + stream_id = sdw_ins->stream_id; > + switch (stream_id) { > + case ACP_SDW_AUDIO_TX: > + sdw_dma_reg = ACP_SW_AUDIO_TX_EN; > + sdw_dma_en_stat_reg = ACP_SW_AUDIO_TX_EN_STATUS; > + break; Not super urgent but if you're respinning then it looks like the register selection here is the same in _dma_stop() so they could be shared. Indeed it generally feels like it might be nicer to have a table of structs listing the registers needed per stream so all these switch statements can be more like sdw_dma_reg = stream_registers[sdw_ins->stream_id]; That'd make each function smaller and I'd expect it'd be a bit easier to add new streams for new hardware that way. --ag3m81g3IJWqkKTr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmO+s+4ACgkQJNaLcl1U h9DLbAf/Y4NTcfbaVytJnLOHnw0v/nbCxi1SzVDhzKx3adrIi2mK0rjmw1rH8Ic/ OX1xBbmsovdG69oGTI3m7stFElnvH8/xOhKPjyzN1KcDIe9fxCUTmvblRGdBfkE3 jWUSbT6JI+d7b8LxYy7aEclwebLOmbhvDZiGYTasbF9POtj1msqx9J1w++XVpRj0 PS8pKMs/VIGrO+dsyYxmQwR/jkadmkecR1vpcnhy7cYGDJC0UBlh//LEwiM4E6Ta sIRPq6ExQl3Vt21Xq7be5DFHueF3hgnqochCD5Kx/UmudA1b5iPzvIApPoTmNPUm j4jObBg8qnHUvv03RkbfqEBsuGGAjg== =PM/9 -----END PGP SIGNATURE----- --ag3m81g3IJWqkKTr--