From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5581C46467 for ; Wed, 11 Jan 2023 15:16:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229581AbjAKPQo (ORCPT ); Wed, 11 Jan 2023 10:16:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233540AbjAKPQZ (ORCPT ); Wed, 11 Jan 2023 10:16:25 -0500 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B6A610FCE for ; Wed, 11 Jan 2023 07:16:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1673450164; bh=YNrKjl0vmk6HeouqfJhW2pIt2UMY1ihv0siZV1VSDW4=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=QzmGV9ST6Tx/JWgXbB8PKWucyMsszLwRU2XvicoXikQH70DCNTBrUiYlYAtoJVIrB OC9S6jkF81gEanWwMdznW0t3Ytl9jGtpTwlEcUN4WKMEIy14UTcfH4GteaXNZSt0hJ WmUq/2yjh2K+vmlKWRQO8otcvZTACrCSMdSXjL+s= Received: by b-3.in.mailobj.net [192.168.90.13] with ESMTP via ip-206.mailobj.net [213.182.55.206] Wed, 11 Jan 2023 16:16:04 +0100 (CET) X-EA-Auth: o5gHe/4cJ51Rp5I5pe1ZiHmrLwLGpoGjvlDg5k9FZ2Oo6L8x+3udqTkDD+PZMVM85Ohmp16ZF4lftHRYojd0ulsezvjfq+jV Date: Wed, 11 Jan 2023 20:46:00 +0530 From: Deepak R Varma To: Rodrigo Vivi Cc: Tvrtko Ursulin , Saurabh Singh Sengar , dri-devel@lists.freedesktop.org, Praveen Kumar , intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Zhi Wang Subject: Re: [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for vgpu_status debug attributes Message-ID: References: <188df08e0feba0cda2c92145f513dd4e57c6e6cf.1673375066.git.drv@mailo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2023 at 10:00:11AM -0500, Rodrigo Vivi wrote: > > > Actually, could you please address the checkpatch issues before we can push? > > > Sorry about that, but just noticed now when I was going to push the other ones. > > > > Hello Rodrigo, > > The checkpatch warning is associated with the long "make coccicheck ..." command > > in the commit message. It is not part of the code, so is should not be carried > > forward into the code base. > > If you still want me to correct it, I will need to split it into two lines which > > I think still violates the commit description guidelines. > > This part I would just ignore or fix myself while merging. But the next one about > the parenthesis alignment need to be fixed in the code so we need another version. > Since we try to avoid touching the code between CI and merge. I am sorry, but I am unable to locate the "second checkpatch complaint" you are referring to. I have received only the following from the checkpatch robot: == Summary == Error: dim checkpatch failed 4c95e9b71212 drm/i915/gvt: Avoid full proxy f_ops for scan_nonprivbb debug attributes -:21: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #21: make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci total: 0 errors, 1 warnings, 0 checks, 22 lines checked 33d68a01cad3 drm/i915/gvt: Avoid full proxy f_ops for vgpu_status debug attributes -:21: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #21: make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci total: 0 errors, 1 warnings, 0 checks, 18 lines checked =============================== > > Then, since you need to change that, while changing that, also please break > the coccinelle line in the commit msg. > > I'd appreciate to have the patch for the pxp as well :) Sure. As mentioned in the other thread, I am looking into it and would submit a patch accordingly. Thank you, ./drv > > Thanks a lot, > Rodrigo. > > > > > > Let me know what you think. > > > > Thank you, > > ./drv > > > > > > > > > > > > > > --- > > > > > drivers/gpu/drm/i915/gvt/debugfs.c | 6 +++--- > > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/i915/gvt/debugfs.c b/drivers/gpu/drm/i915/gvt/debugfs.c > > > > > index 03f081c3d9a4..baccbf1761b7 100644 > > > > > --- a/drivers/gpu/drm/i915/gvt/debugfs.c > > > > > +++ b/drivers/gpu/drm/i915/gvt/debugfs.c > > > > > @@ -165,7 +165,7 @@ static int vgpu_status_get(void *data, u64 *val) > > > > > return 0; > > > > > } > > > > > > > > > > -DEFINE_SIMPLE_ATTRIBUTE(vgpu_status_fops, vgpu_status_get, NULL, "0x%llx\n"); > > > > > +DEFINE_DEBUGFS_ATTRIBUTE(vgpu_status_fops, vgpu_status_get, NULL, "0x%llx\n"); > > > > > > > > > > /** > > > > > * intel_gvt_debugfs_add_vgpu - register debugfs entries for a vGPU > > > > > @@ -182,8 +182,8 @@ void intel_gvt_debugfs_add_vgpu(struct intel_vgpu *vgpu) > > > > > &vgpu_mmio_diff_fops); > > > > > debugfs_create_file_unsafe("scan_nonprivbb", 0644, vgpu->debugfs, vgpu, > > > > > &vgpu_scan_nonprivbb_fops); > > > > > - debugfs_create_file("status", 0644, vgpu->debugfs, vgpu, > > > > > - &vgpu_status_fops); > > > > > + debugfs_create_file_unsafe("status", 0644, vgpu->debugfs, vgpu, > > > > > + &vgpu_status_fops); > > > > > } > > > > > > > > > > /** > > > > > -- > > > > > 2.34.1 > > > > > > > > > > > > > > > > > > >