From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Umang Jain <umang.jain@ideasonboard.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Kees Cook <keescook@chromium.org>,
Stefan Wahren <stefan.wahren@i2se.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Adrien Thierry <athierry@redhat.com>,
Dan Carpenter <error27@gmail.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: Re: [PATCH v3 0/7] staging: vc04_services: Remove custom return values
Date: Wed, 11 Jan 2023 18:26:47 +0200 [thread overview]
Message-ID: <Y77jR5i+q9Flu0si@pendragon.ideasonboard.com> (raw)
In-Reply-To: <ba52e6b4-33ec-622e-00b6-1b098f529a90@ideasonboard.com>
Hi Umang,
On Wed, Jan 11, 2023 at 02:32:17PM +0530, Umang Jain wrote:
> Hi all,
>
> Gentle ping for review, If it's needs more iterations or ready to be
> accepted...
I see that Stefan has tested the whole series. Florian is listed as the
maintainer for vc04_services. Florian, do you want to review this series
further, or can we merge it in v6.3 ?
> On 12/23/22 5:53 PM, Umang Jain wrote:
> > The series removes the custom return values from functions
> > and replaces them with linux error codes. This address the TODO
> > vchiq interface:
> > * Get rid of custom function return values
> >
> > Changes in v3:
> > - Drop fixes tag for 5/7 as suggested in review
> > - Add Tested-by: by Stefan Wahren to the series
> >
> > Changes in V2:
> > - Patch 3/7 now reports for specific errors like -ENOMEM, -EHOSTDOWN
> > - Patch 5/7 reports -ENOTCONN instead of -EINVAL and adds a "Fixes" tag
> >
> > Umang Jain (7):
> > staging: vc04_services: Replace vchiq_status return type to int
> > staging: vc04_services: Drop VCHIQ_SUCCESS usage
> > staging: vc04_services: Drop VCHIQ_ERROR usage
> > staging: vc04_services: Drop VCHIQ_RETRY usage
> > vc04_services: vchiq_arm: Drop VCHIQ_RETRY usage on disconnect
> > staging: vc04_services: Drop enum vchiq_status remnants
> > staging: vc04_services: vchiq: Drop custom return values from TODO
> >
> > .../bcm2835-audio/bcm2835-vchiq.c | 12 +-
> > .../include/linux/raspberrypi/vchiq.h | 65 +++---
> > drivers/staging/vc04_services/interface/TODO | 5 -
> > .../interface/vchiq_arm/vchiq_arm.c | 124 +++++-----
> > .../interface/vchiq_arm/vchiq_arm.h | 12 +-
> > .../interface/vchiq_arm/vchiq_core.c | 216 +++++++++---------
> > .../interface/vchiq_arm/vchiq_core.h | 18 +-
> > .../interface/vchiq_arm/vchiq_dev.c | 36 +--
> > .../interface/vchiq_arm/vchiq_ioctl.h | 8 +-
> > .../vc04_services/vchiq-mmal/mmal-vchiq.c | 11 +-
> > 10 files changed, 246 insertions(+), 261 deletions(-)
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2023-01-11 16:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 12:23 Umang Jain
2022-12-23 12:23 ` [PATCH v3 1/7] staging: vc04_services: Replace vchiq_status return type to int Umang Jain
2022-12-23 12:23 ` [PATCH v3 2/7] staging: vc04_services: Drop VCHIQ_SUCCESS usage Umang Jain
2022-12-23 12:24 ` [PATCH v3 3/7] staging: vc04_services: Drop VCHIQ_ERROR usage Umang Jain
2022-12-23 12:24 ` [PATCH v3 4/7] staging: vc04_services: Drop VCHIQ_RETRY usage Umang Jain
2022-12-23 12:24 ` [PATCH v3 5/7] vc04_services: vchiq_arm: Drop VCHIQ_RETRY usage on disconnect Umang Jain
2022-12-23 12:24 ` [PATCH v3 6/7] staging: vc04_services: Drop enum vchiq_status remnants Umang Jain
2022-12-23 12:24 ` [PATCH v3 7/7] staging: vc04_services: vchiq: Drop custom return values from TODO Umang Jain
2023-01-11 9:02 ` [PATCH v3 0/7] staging: vc04_services: Remove custom return values Umang Jain
2023-01-11 16:26 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y77jR5i+q9Flu0si@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=athierry@redhat.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=error27@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=stefan.wahren@i2se.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®