From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFFB6C5479D for ; Mon, 2 Jan 2023 13:09:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232587AbjABNJi (ORCPT ); Mon, 2 Jan 2023 08:09:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229526AbjABNJg (ORCPT ); Mon, 2 Jan 2023 08:09:36 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D15B72AE3; Mon, 2 Jan 2023 05:09:35 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BA2EA7C5; Mon, 2 Jan 2023 14:09:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1672664973; bh=zIk6QQNUSftzZ+hGLOFlX3yOnoZ98+39j7t0QiP1bMc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i+F7T6+qUfCRnFGVOaNGqS8fMVVRPVbBGa46KSSWiCMAJ/mUZWi1FE4cCjmYtMhr9 QCs6KuO8K0Eo4SSW2I9758V12XC9PuH50n+KyT48t+Amen42nNygWa+FcJ/FtBGj8Y 7IPr90saLP9i3WQV3vgAopAe4AsDPeo6ee1QaCfU= Date: Mon, 2 Jan 2023 15:09:30 +0200 From: Laurent Pinchart To: Rahul T R Cc: dri-devel@lists.freedesktop.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, tomi.valkeinen@ideasonboard.com, andrzej.hajda@intel.com, narmstrong@baylibre.com, robert.foss@linaro.org, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch, p.zabel@pengutronix.de, linux-kernel@vger.kernel.org, jpawar@cadence.com, sjakhade@cadence.com, mparab@cadence.com, a-bhatia1@ti.com, devicetree@vger.kernel.org, vigneshr@ti.com, lee.jones@linaro.org, Rob Herring Subject: Re: [PATCH v10 1/5] dt-bindings: display: bridge: Convert cdns,dsi.txt to yaml Message-ID: References: <20230102100942.1828-1-r-ravikumar@ti.com> <20230102100942.1828-2-r-ravikumar@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230102100942.1828-2-r-ravikumar@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rahul, Thank you for the patch. On Mon, Jan 02, 2023 at 03:39:38PM +0530, Rahul T R wrote: > Convert cdns,dsi.txt binding to yaml format > > Signed-off-by: Rahul T R > Reviewed-by: Rob Herring > --- > .../bindings/display/bridge/cdns,dsi.txt | 112 ------------- > .../bindings/display/bridge/cdns,dsi.yaml | 157 ++++++++++++++++++ > 2 files changed, 157 insertions(+), 112 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,dsi.txt > create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,dsi.txt b/Documentation/devicetree/bindings/display/bridge/cdns,dsi.txt > deleted file mode 100644 > index 525a4bfd8634..000000000000 > --- a/Documentation/devicetree/bindings/display/bridge/cdns,dsi.txt > +++ /dev/null > @@ -1,112 +0,0 @@ > -Cadence DSI bridge > -================== > - > -The Cadence DSI bridge is a DPI to DSI bridge supporting up to 4 DSI lanes. > - > -Required properties: > -- compatible: should be set to "cdns,dsi". > -- reg: physical base address and length of the controller's registers. > -- interrupts: interrupt line connected to the DSI bridge. > -- clocks: DSI bridge clocks. > -- clock-names: must contain "dsi_p_clk" and "dsi_sys_clk". > -- phys: phandle link to the MIPI D-PHY controller. > -- phy-names: must contain "dphy". > -- #address-cells: must be set to 1. > -- #size-cells: must be set to 0. > - > -Optional properties: > -- resets: DSI reset lines. > -- reset-names: can contain "dsi_p_rst". > - > -Required subnodes: > -- ports: Ports as described in Documentation/devicetree/bindings/graph.txt. > - 2 ports are available: > - * port 0: this port is only needed if some of your DSI devices are > - controlled through an external bus like I2C or SPI. Can have at > - most 4 endpoints. The endpoint number is directly encoding the > - DSI virtual channel used by this device. > - * port 1: represents the DPI input. > - Other ports will be added later to support the new kind of inputs. > - > -- one subnode per DSI device connected on the DSI bus. Each DSI device should > - contain a reg property encoding its virtual channel. > - > -Example: > - dsi0: dsi@fd0c0000 { > - compatible = "cdns,dsi"; > - reg = <0x0 0xfd0c0000 0x0 0x1000>; > - clocks = <&pclk>, <&sysclk>; > - clock-names = "dsi_p_clk", "dsi_sys_clk"; > - interrupts = <1>; > - phys = <&dphy0>; > - phy-names = "dphy"; > - #address-cells = <1>; > - #size-cells = <0>; > - > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@1 { > - reg = <1>; > - dsi0_dpi_input: endpoint { > - remote-endpoint = <&xxx_dpi_output>; > - }; > - }; > - }; > - > - panel: dsi-dev@0 { > - compatible = ""; > - reg = <0>; > - }; > - }; > - > -or > - > - dsi0: dsi@fd0c0000 { > - compatible = "cdns,dsi"; > - reg = <0x0 0xfd0c0000 0x0 0x1000>; > - clocks = <&pclk>, <&sysclk>; > - clock-names = "dsi_p_clk", "dsi_sys_clk"; > - interrupts = <1>; > - phys = <&dphy1>; > - phy-names = "dphy"; > - #address-cells = <1>; > - #size-cells = <0>; > - > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@0 { > - reg = <0>; > - #address-cells = <1>; > - #size-cells = <0>; > - > - dsi0_output: endpoint@0 { > - reg = <0>; > - remote-endpoint = <&dsi_panel_input>; > - }; > - }; > - > - port@1 { > - reg = <1>; > - dsi0_dpi_input: endpoint { > - remote-endpoint = <&xxx_dpi_output>; > - }; > - }; > - }; > - }; > - > - i2c@xxx { > - panel: panel@59 { > - compatible = ""; > - reg = <0x59>; > - > - port { > - dsi_panel_input: endpoint { > - remote-endpoint = <&dsi0_output>; > - }; > - }; > - }; > - }; > diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml > new file mode 100644 > index 000000000000..3161c33093c1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml > @@ -0,0 +1,157 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/cdns,dsi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cadence DSI bridge > + > +maintainers: > + - Boris Brezillon > + > +description: | > + CDNS DSI is a bridge device which converts DPI to DSI > + > +properties: > + compatible: > + enum: > + - cdns,dsi > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: PSM clock, used by the IP > + - description: sys clock, used by the IP > + > + clock-names: > + items: > + - const: dsi_p_clk > + - const: dsi_sys_clk > + > + phys: > + maxItems: 1 > + > + phy-names: > + const: dphy > + > + interrupts: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + reset-names: > + const: dsi_p_rst > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output port representing the DSI output. It can have > + at most 4 endpoints. The endpoint number is directly encoding > + the DSI virtual channel used by this device. Using endpoints to model virtual channels isn't great, but that's not an issue with this patch. Reviewed-by: Laurent Pinchart > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Input port representing the DPI input. > + > + required: > + - port@1 > + > +allOf: > + - $ref: ../dsi-controller.yaml# > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - phys > + - phy-names > + - ports > + > +unevaluatedProperties: false > + > +examples: > + - | > + bus { > + #address-cells = <2>; > + #size-cells = <2>; > + > + dsi@fd0c0000 { > + compatible = "cdns,dsi"; > + reg = <0x0 0xfd0c0000 0x0 0x1000>; > + clocks = <&pclk>, <&sysclk>; > + clock-names = "dsi_p_clk", "dsi_sys_clk"; > + interrupts = <1>; > + phys = <&dphy0>; > + phy-names = "dphy"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@1 { > + reg = <1>; > + endpoint { > + remote-endpoint = <&xxx_dpi_output>; > + }; > + }; > + }; > + > + panel@0 { > + compatible = "panasonic,vvx10f034n00"; > + reg = <0>; > + power-supply = <&vcc_lcd_reg>; > + }; > + }; > + }; > + > + - | > + bus { > + #address-cells = <2>; > + #size-cells = <2>; > + > + dsi@fd0c0000 { > + compatible = "cdns,dsi"; > + reg = <0x0 0xfd0c0000 0x0 0x1000>; > + clocks = <&pclk>, <&sysclk>; > + clock-names = "dsi_p_clk", "dsi_sys_clk"; > + interrupts = <1>; > + phys = <&dphy1>; > + phy-names = "dphy"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + endpoint@0 { > + reg = <0>; > + remote-endpoint = <&dsi_panel_input>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + endpoint { > + remote-endpoint = <&xxx_dpi_output>; > + }; > + }; > + }; > + }; > + }; -- Regards, Laurent Pinchart