From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C48FC4708E for ; Mon, 2 Jan 2023 14:06:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236148AbjABOGv (ORCPT ); Mon, 2 Jan 2023 09:06:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229864AbjABOGs (ORCPT ); Mon, 2 Jan 2023 09:06:48 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9627CB77 for ; Mon, 2 Jan 2023 06:06:47 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id D5B6033F2B; Mon, 2 Jan 2023 14:06:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1672668405; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vXSMBD5V/kRdKgsprcG9zzLSl5h3pHLEyJFv0HWtoBs=; b=bA5GEcuYSbPiTGsC3cOvD442HSroXij0LjOjw4La92p6INaOwb9CMngpKVRKblJqxqzste BZuOKql0TB2VXjb8odTeTVKyIwXIYYXwE6QXzl3y+D900Cfi3H6MqLhn76kAh6AHDazMhD bs6MfMgqjx8lT9CsvNWEJLtZmtOf6VY= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 86EEB2C141; Mon, 2 Jan 2023 14:06:45 +0000 (UTC) Date: Mon, 2 Jan 2023 15:06:43 +0100 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH printk v3 1/6] printk: move size limit macros into internal.h Message-ID: References: <20221221202704.857925-1-john.ogness@linutronix.de> <20221221202704.857925-2-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221221202704.857925-2-john.ogness@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2022-12-21 21:32:59, John Ogness wrote: > The size limit macros are located further down in printk.c and > behind ifdef macros. This complicates their usage for upcoming > changes. Move the macros into internal.h so that they are still > invisible outside of printk, but easily accessible for printk. > > Also, the maximum size of formatted extended messages does not > need to be known by any code outside of printk, so move it to > internal.h as well. And like CONSOLE_LOG_MAX, for !CONFIG_PRINTK > set CONSOLE_EXT_LOG_MAX to 0 to reduce the static memory > footprint. > > Signed-off-by: John Ogness Reviewed-by: Petr Mladek Best Regards, Petr