mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Lukasz Majewski <lukma@denx.de>
Cc: Vladimir Oltean <olteanv@gmail.com>,
	Eric Dumazet <edumazet@google.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Paolo Abeni <pabeni@redhat.com>,
	Alexander Duyck <alexander.duyck@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Subject: Re: [PATCH v3 2/3] net: dsa: mv88e6xxx: add support for MV88E6020 switch
Date: Mon, 2 Jan 2023 21:00:06 +0100	[thread overview]
Message-ID: <Y7M3xg0mJhhr8Xg8@lunn.ch> (raw)
In-Reply-To: <20230102150209.985419-2-lukma@denx.de>

On Mon, Jan 02, 2023 at 04:02:08PM +0100, Lukasz Majewski wrote:
> From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> 
> A mv88e6250 family (i.e. LinkStreet) switch with 2 PHY and RMII ports
> and no PTP support.

>  static const struct mv88e6xxx_info mv88e6xxx_table[] = {
> +	[MV88E6020] = {
> +		.prod_num = MV88E6XXX_PORT_SWITCH_ID_PROD_6020,
> +		.family = MV88E6XXX_FAMILY_6250,
> +		.name = "Marvell 88E6020",
> +		.num_databases = 64,
> +		.num_ports = 7,
> +		.num_internal_phys = 5,

You say in the commit message there are two PHYs, yet you have 5 here?

    Andrew

  reply	other threads:[~2023-01-02 20:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-02 15:02 [PATCH v3 1/3] dsa: marvell: Provide per device information about max frame size Lukasz Majewski
2023-01-02 15:02 ` [PATCH v3 2/3] net: dsa: mv88e6xxx: add support for MV88E6020 switch Lukasz Majewski
2023-01-02 20:00   ` Andrew Lunn [this message]
2023-01-03  8:46     ` Lukasz Majewski
2023-01-02 15:02 ` [PATCH v3 3/3] net: dsa: mv88e6xxx: add support for MV88E6071 switch Lukasz Majewski
2023-01-02 19:58 ` [PATCH v3 1/3] dsa: marvell: Provide per device information about max frame size Andrew Lunn
2023-01-02 20:29 ` Andrew Lunn
2023-01-03  9:02   ` Lukasz Majewski
2023-01-03 12:54     ` Andrew Lunn
2023-01-05 10:37     ` Lukasz Majewski
2023-01-05 16:13       ` Alexander Duyck
2023-01-05 17:44         ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y7M3xg0mJhhr8Xg8@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=alexander.duyck@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=lukma@denx.de \
    --cc=matthias.schiffer@ew.tq-group.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®