From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0CA6C46467 for ; Wed, 4 Jan 2023 10:20:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234593AbjADKUb (ORCPT ); Wed, 4 Jan 2023 05:20:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234341AbjADKUN (ORCPT ); Wed, 4 Jan 2023 05:20:13 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95C97193FA; Wed, 4 Jan 2023 02:20:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672827612; x=1704363612; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=NPxQWNdyTdWqkzxmEAyoSSF71GDzFceR3vK9LEhdjnM=; b=MthnFznTiRTzQ3v8xqp/RJdfQ43alquLjWC8DqbAOmet/rw9oOqf6uKN J0QyGNgNQF39K8/DiSgj1JOJzJykVfo4WIUgJCL8xL5t8/ExIxKbTHev9 exthv+HbIghs3t0gv6Q7bK++HmQjSAMnKjLM56HSgKDwJCdrNUQz+C5CW E1nRYQOQ6qy9bOvpyazZe8WLu7UTOI7I5djYMH75CwBxZjfJgnhFSR3jc unv0/4TqCq/t4ezM+01oIjBpSPJSYKh/DzddNmlV9kcRZHH5dODe4uuek 2YbmcAbX6/UaFciMGoBJiavWX4fdZQD+SZhlwP2VcFBfqh+blmmRLXZqn g==; X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="349124524" X-IronPort-AV: E=Sophos;i="5.96,299,1665471600"; d="scan'208";a="349124524" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 02:20:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10579"; a="797481111" X-IronPort-AV: E=Sophos;i="5.96,299,1665471600"; d="scan'208";a="797481111" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP; 04 Jan 2023 02:20:10 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pD0sT-004G40-0m; Wed, 04 Jan 2023 12:20:09 +0200 Date: Wed, 4 Jan 2023 12:20:08 +0200 From: Andy Shevchenko To: Benjamin Mugnier Cc: Sakari Ailus , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Sylvain Petinot , Mauro Carvalho Chehab Subject: Re: [PATCH v1 1/1] media: i2c: st-vgxy61: Use asm intead of asm-generic Message-ID: References: <20230103145219.40226-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 04, 2023 at 10:27:14AM +0100, Benjamin Mugnier wrote: > On 1/3/23 15:52, Andy Shevchenko wrote: ... > > -#include > > #include > > #include > > #include > > @@ -15,6 +14,9 @@ > > #include > > #include > > #include > > + > > +#include > Any particular reason not to keep the alphabetical sort ? It's kept in an order in each of the groups of headers. The main rule here is to go from most generic headers to the particular ones. asm/* are definitely more particular than linux/* ones. > > #include > > #include > > #include -- With Best Regards, Andy Shevchenko