From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9CAEC3DA7A for ; Thu, 5 Jan 2023 17:01:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234172AbjAERAr (ORCPT ); Thu, 5 Jan 2023 12:00:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234803AbjAERAh (ORCPT ); Thu, 5 Jan 2023 12:00:37 -0500 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C33754DAA; Thu, 5 Jan 2023 09:00:37 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id d15so39939047pls.6; Thu, 05 Jan 2023 09:00:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=lWuNYcgMRUdXt3lrKpOOAhpTNHvmJnhLtWA6WFPkqzw=; b=Ip639JaYOV1aW93fhR9fwRH10jtovSU7bc+87GLEpQ+7rAxYP89lDQrJAJsr2FX6W4 aI4VpoefbHI4W7mUgseXFMeB3elqfgJAmZIvaMFo5/s6Z0OjDK3eHaWaHAmCn0uFnX6t kOHaQWZWvNX8ogHf+qeBkzT3vQbBpAo48dSLguLwXtrFfBJXmtjwkHNqJUhPzdXc6PkS BDkw7vuxKXEyvEu4F9Bk2v+2c9TDA3TXClOaIDNfSxIYjOkAwt6/suSKu1swOAB2Ut44 rhTI0gv4n6qsAGEuBQGHyBx0fZFcj9lXGw6KBaKYwIypB0W5q90hjWTlQKrYwgVG5yUy JbhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lWuNYcgMRUdXt3lrKpOOAhpTNHvmJnhLtWA6WFPkqzw=; b=TAxQWxHlVfoOXJz22YiBaCVYN5qXikQAt+XDMMYkIhY/1dwueouziYYRK0x2Q5MUjz HMgaYEWZAa29YFa1RvdPREukV4RYQZLfw+MHX0cd/RAYWQdPZtnGncMn3ruuqdnI0DGw C8QNVNbgEfhAoT8p6AWBl+CJLhJa520Zkb26q+ovJqP6Th+mCmdT/YDsrkiJGqtH2NdR kljw9sv3q6icY0BpQWnvscN1KY8oAkAQOUySXyDFSbWiLzw14qUv1aGu1FDOvd1siOvA B8fV+yqRbt8Vp/bCLS2WpNvUYtQ6o/8sVsKcOEhQ0SHf1GlXAZEY276Cy2ZVE8dC9yZH 8DHQ== X-Gm-Message-State: AFqh2krxoqiVhl4JxsxIDaU4/aYBkQg8hp4NzxaceQ0aq7ZAHaKWsqT3 17w5v7tMMqkWJzJdV/kE1eA= X-Google-Smtp-Source: AMrXdXt4uRQVRgPNn+82sQpY7HLkRbMOO20I+dRTWJJ/bfU20RYAkQ2J+eEF8mhTo+v0yZuvmxdXlA== X-Received: by 2002:a05:6a20:9591:b0:ad:7428:d326 with SMTP id iu17-20020a056a20959100b000ad7428d326mr70011472pzb.30.1672938036598; Thu, 05 Jan 2023 09:00:36 -0800 (PST) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id k201-20020a6284d2000000b005822ce3b2acsm10560119pfd.115.2023.01.05.09.00.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 09:00:36 -0800 (PST) Sender: Tejun Heo Date: Thu, 5 Jan 2023 07:00:35 -1000 From: Tejun Heo To: Yu Kuai Cc: josef@toxicpanda.com, axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: Re: [PATCH] blk-cgroup: fix missing pd_online_fn() while activating policy Message-ID: References: <20230103112833.2013432-1-yukuai1@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230103112833.2013432-1-yukuai1@huaweicloud.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 03, 2023 at 07:28:33PM +0800, Yu Kuai wrote: > From: Yu Kuai > > If the policy defines pd_online_fn(), it should be called after > pd_init_fn(), like blkg_create(). > > Signed-off-by: Yu Kuai Acked-by: Tejun Heo However, it'd be useful to note the practical implication of the bug in the patch description, which seems like not much as discussed in the thread. Thanks. -- tejun