From: Borislav Petkov <bp@alien8.de>
To: "Zhang, Rui" <rui.zhang@intel.com>
Cc: "Hansen, Dave" <dave.hansen@intel.com>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"kan.liang@linux.intel.com" <kan.liang@linux.intel.com>,
"Bityutskiy, Artem" <artem.bityutskiy@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] perf/x86/rapl: Add support for Intel Meteor Lake
Date: Fri, 6 Jan 2023 15:49:56 +0100 [thread overview]
Message-ID: <Y7g1FCY4Y+hY26aC@zn.tnic> (raw)
In-Reply-To: <d6ae35f1e72d4bb8e02f44fe6d9369f1a5f21619.camel@intel.com>
On Fri, Jan 06, 2023 at 02:38:10PM +0000, Zhang, Rui wrote:
> And then set the feature flags based on this, and make the drivers test
> the feature flags.
That would be the purpose of synthetic flags.
> The goal of this is to do model list update in one place instead of 4
> or more different drivers when a new model comes.
Do you really have to update 4 different places each time?
As said before, you have to do the model matching *somewhere*. If you have to do
model matching in a lot of drivers - and it looks like you do - judging by
$ git grep X86_MATCH_INTEL_FAM6
output, then doing the matching once in cpu/intel.c and setting a synthetic flag
does make sense because all that matching code will disappear from all the
drivers but be concentrated in one place.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2023-01-06 14:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 14:58 Zhang Rui
2023-01-04 14:58 ` [PATCH 2/2] perf/x86/rapl: Add support for Intel Emerald Rapids Zhang Rui
2023-01-04 20:08 ` [tip: perf/urgent] " tip-bot2 for Zhang Rui
2023-01-04 16:55 ` [PATCH 1/2] perf/x86/rapl: Add support for Intel Meteor Lake Dave Hansen
2023-01-05 6:54 ` Zhang, Rui
2023-01-05 9:55 ` Borislav Petkov
2023-01-06 6:05 ` Zhang, Rui
2023-01-06 10:14 ` Ingo Molnar
2023-01-06 10:39 ` Borislav Petkov
2023-01-06 10:56 ` Ingo Molnar
2023-01-06 11:11 ` Borislav Petkov
2023-01-06 11:33 ` Ingo Molnar
2023-01-06 14:45 ` Zhang, Rui
2023-01-06 14:38 ` Zhang, Rui
2023-01-06 14:49 ` Borislav Petkov [this message]
2023-01-06 14:50 ` Dave Hansen
2023-01-07 14:07 ` Zhang, Rui
2023-01-04 20:08 ` [tip: perf/urgent] " tip-bot2 for Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7g1FCY4Y+hY26aC@zn.tnic \
--to=bp@alien8.de \
--cc=ak@linux.intel.com \
--cc=artem.bityutskiy@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rui.zhang@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®