From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH printk v4 0/8] printk: cleanup buffer handling
Date: Fri, 6 Jan 2023 12:21:58 +0100 [thread overview]
Message-ID: <Y7gEVpMTvI0WzPH7@alley> (raw)
In-Reply-To: <20230105103735.880956-1-john.ogness@linutronix.de>
On Thu 2023-01-05 11:43:27, John Ogness wrote:
> Hi,
>
> This is v4 of a series to cleanup console buffer handling and
> prepare for code sharing with the upcoming threaded/atomic
> consoles. v3 is here [0].
>
> The main purpose of the series is to introduce two new lockless
> functions to handle reading and formatting of printk messages. These
> functions can then be used from any context, which is important for
> the upcoming threaded/atomic consoles. The series also helps to
> cleanup some of the internal printk interfaces and cleanly separate
> formatting code from outputting code.
>
> John Ogness (6):
> printk: move size limit macros into internal.h
> printk: introduce struct printk_buffers
> printk: introduce printk_get_next_message() and printk_message
> printk: introduce console_prepend_dropped() for dropped messages
This patch would need a followup fix to prevent the compiler warning.
> printk: use printk_buffers for devkmsg
This one would need respin to fix the problem with suppressed messages.
> printk: adjust string limit macros
>
> Thomas Gleixner (2):
> console: Use BIT() macros for @flags values
> console: Document struct console
The rest looks ready for linux-next.
I see three ways how to move forward:
1. Respin the entire patchset.
2. Respin only 7th patch + send the follow up fix seperately
3. Push first 6 patches and handle the rest separately.
What would be more convenient for you, please?
Honestly, I do not have any real preference.
Best Regards,
Petr
next prev parent reply other threads:[~2023-01-06 11:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 10:37 John Ogness
2023-01-05 10:37 ` [PATCH printk v4 1/8] printk: move size limit macros into internal.h John Ogness
2023-01-05 14:48 ` Petr Mladek
2023-01-05 10:37 ` [PATCH printk v4 2/8] console: Use BIT() macros for @flags values John Ogness
2023-01-05 10:37 ` [PATCH printk v4 3/8] console: Document struct console John Ogness
2023-01-05 10:37 ` [PATCH printk v4 4/8] printk: introduce struct printk_buffers John Ogness
2023-01-05 15:06 ` Petr Mladek
2023-01-05 10:37 ` [PATCH printk v4 5/8] printk: introduce printk_get_next_message() and printk_message John Ogness
2023-01-05 15:24 ` Petr Mladek
2023-01-05 10:37 ` [PATCH printk v4 6/8] printk: introduce console_prepend_dropped() for dropped messages John Ogness
2023-01-05 16:17 ` Petr Mladek
2023-01-05 16:35 ` John Ogness
2023-01-06 9:34 ` Petr Mladek
2023-01-05 10:37 ` [PATCH printk v4 7/8] printk: use printk_buffers for devkmsg John Ogness
2023-01-05 12:14 ` John Ogness
2023-01-05 12:16 ` [PATCH printk v4 7/8 v2] " John Ogness
2023-01-06 10:39 ` Petr Mladek
2023-01-08 21:11 ` John Ogness
2023-01-05 10:37 ` [PATCH printk v4 8/8] printk: adjust string limit macros John Ogness
2023-01-06 11:11 ` Petr Mladek
2023-01-06 11:21 ` Petr Mladek [this message]
2023-01-07 8:18 ` [PATCH printk v4 0/8] printk: cleanup buffer handling John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7gEVpMTvI0WzPH7@alley \
--to=pmladek@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®