From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27EBCC54EBF for ; Fri, 6 Jan 2023 16:26:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235347AbjAFQ0h (ORCPT ); Fri, 6 Jan 2023 11:26:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234091AbjAFQ0c (ORCPT ); Fri, 6 Jan 2023 11:26:32 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1BFD3E858; Fri, 6 Jan 2023 08:26:31 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5D96BB81DDE; Fri, 6 Jan 2023 16:26:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7DA2C433D2; Fri, 6 Jan 2023 16:26:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673022389; bh=jWB+sN7NrEajAweWKZpqeUW/3yCctjfcPWzZp9GCvNQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dOpdXagINOab8jxuJQkJI+qER+/XiBLXJ/M86brz8ojFo4gs3UlnlW3faeTla9lTK t/ztyWgcC+mhqmUnqGR6aLJGRtn5RmsCgrE1E+TLF/tShnZGT7C61dx0cjKHyOkNXL 6Nt44LTixnjWLfsOkqvXYDVkNIRkE1c42gnAqKc//tn8tRnTB0HK7WVF8+WM4+KBVD MjRHxiFHO0qD7b8JMVSqo13OmDgdMcwD1dpsgCCMwGYM2Stwt0jl6LvtxTIFmX8gLZ 5gdG5X8Ywj+M4O2tKj5KjU/7EDrPMyfiEgvFZ+Y8cLzXKcnO2leJFZ17AvH+fI0x6N DgQD2kvggwS/Q== Date: Fri, 6 Jan 2023 16:26:23 +0000 From: Mark Brown To: Janne Grunau , Rob Herring , Krzysztof Kozlowski , Hector Martin Cc: Tudor Ambarus , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, Alyssa Rosenzweig , asahi@lists.linux.dev, linux-kernel@vger.kernel.org, Hector Martin Subject: Re: [PATCH 3/5] spi: Use a 32-bit DT property for spi-cs-setup-delay-ns Message-ID: References: <20230104093631.15611-4-marcan@marcan.st> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="c+1eWrxib7oClGdE" Content-Disposition: inline In-Reply-To: <20230104093631.15611-4-marcan@marcan.st> X-Cookie: System going down in 5 minutes. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --c+1eWrxib7oClGdE Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 04, 2023 at 06:36:29PM +0900, Janne Grunau wrote: > 65us is not a reasonable maximum for this property, as some devices > might need a much longer setup time (e.g. those driven by firmware on > the other end). Plus, device tree property values are in 32-bit cells > and smaller widths should not be used without good reason. This breaks allmodconfig builds (I tested x86 but this should happen for anything with -Werror): /build/stage/linux/drivers/spi/spi.c: In function =E2=80=98of_spi_parse_dt= =E2=80=99: /build/stage/linux/drivers/spi/spi.c:2243:13: error: unused variable =E2=80= =98cs_setup=E2=80=99 [-Werror=3Dunused-variable] 2243 | u16 cs_setup; | ^~~~~~~~ cc1: all warnings being treated as errors --c+1eWrxib7oClGdE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmO4S64ACgkQJNaLcl1U h9CXLQf/YnI1PGSSqXVvRBi3udlWlcxcl4e3XTdPIfx50uYNZtbMu7wTBBa/z1zD taef+9KGMbp28DCMVaWhefYaFgDUrDk53fB0idts+TdHaX/Uww4BwvLZxwb1oYqu KSPo4rPD5q05N7KtK4Z5JMtQ0ldP3rbk37QuzSZTsF2X7EwNTndsX2RiwBo2KQlv /y2nxQfSA1qlfv6BNSnycJBNkxd283K5WIb0sfM0uc6J4lcF2pISHmx/KszZ+u54 QIS3Y6oaY0YOXTnn/o672+vuSB1I4EaM7mhv/RqLZOW3CgeZl0rSPGvdbXmaRWOd RSBbY2L0j84DkOoVZ5O4Eb62R/7O9g== =nX4z -----END PGP SIGNATURE----- --c+1eWrxib7oClGdE--