From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32CBFC46467 for ; Sat, 7 Jan 2023 20:14:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232725AbjAGUOK (ORCPT ); Sat, 7 Jan 2023 15:14:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230092AbjAGUOC (ORCPT ); Sat, 7 Jan 2023 15:14:02 -0500 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54EF9C757; Sat, 7 Jan 2023 12:13:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1673122432; bh=HH2eHEZl+y1J6jyFsw9Q2SOJYnKKPuwBJha+gp4jMQ0=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=mVJXLZ0lmxF42piqDigDJ7sT4KMkjheq7qi2x/2WdCpQ0d/Nn5AZiQgwPnG/ZMsgf 8FX9uVlNjmUgqoW82cDztUYMVM3jCBPdXiN3OlBfcQqh8+Xki10DlsCpGHJK/h1vzM YBk/Js7kcCAx56OWmGW9QQ2jlgE7hQ4mRHW5lmbE= Received: by b-3.in.mailobj.net [192.168.90.13] with ESMTP via ip-206.mailobj.net [213.182.55.206] Sat, 7 Jan 2023 21:13:52 +0100 (CET) X-EA-Auth: f8+D3POIM0XIqxl0YFEXEeqrBSqzRYP54X7B2nIiew85XgmFGfAKu6vONn6S+H4kXL3dVGALL9yErZamsD/QHyTYkOMaoWOu Date: Sun, 8 Jan 2023 01:43:43 +0530 From: Deepak R Varma To: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar , Praveen Kumar , Deepak R Varma Subject: Re: [PATCH] scsi: aic94xx: Use sysfs_emit in show function callsbacks Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 23, 2022 at 11:20:02PM +0530, Deepak R Varma wrote: > According to Documentation/filesystems/sysfs.rst, the show() callback > function of kobject attributes should strictly use sysfs_emit instead > of sprintf family functions. > Issue identified using the coccinelle device_attr_show.cocci script. > > Signed-off-by: Deepak R Varma > --- Hello, Requesting a review and feedback on this patch proposal. There are a few other similar patches for other scsi drivers that also need your comments. Request to also review those. Thank you, ./drv