From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D5F2C46467 for ; Sat, 7 Jan 2023 20:27:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232710AbjAGU1P (ORCPT ); Sat, 7 Jan 2023 15:27:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230092AbjAGU1M (ORCPT ); Sat, 7 Jan 2023 15:27:12 -0500 Received: from msg-4.mailo.com (msg-4.mailo.com [213.182.54.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1BC934D62 for ; Sat, 7 Jan 2023 12:27:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1673123224; bh=ROZ9pnsepk1j38nhEjI/IvMoppQGZa557ZdPMNDI5Kg=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=Jz9bYQZ4/JxOD9PsSvQ3ifoahe5GQo8NayN2nHwORR5cEDjIGY8t6cVvM1WSG2wLj zanH95YcDOCj85Jl2pbAxXEua2nHFkNUoCR6AJFPHW4ycGs8gSpOaNTtzED0QWa9/m b5EF9YJfaiOPoqXuEMjgZgfNbLuzP8Mg5j4K9PPY= Received: by b-3.in.mailobj.net [192.168.90.13] with ESMTP via ip-206.mailobj.net [213.182.55.206] Sat, 7 Jan 2023 21:27:04 +0100 (CET) X-EA-Auth: ChZckfM5iG3viFbLvzT/xcNn46JA7HWZAA1+SeFdhrWztjEgKvaXU1PHfwuv2tA8HORvuQvHwJqJPJ/eKHCaQxEJw7gzpLKw Date: Sun, 8 Jan 2023 01:56:55 +0530 From: Deepak R Varma To: Ben Skeggs , Karol Herbst , Lyude Paul , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar , Praveen Kumar , Deepak R Varma Subject: Re: [PATCH] drm/nouveau/hwmon: Use sysfs_emit in show function callsbacks Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 25, 2022 at 02:32:08PM +0530, Deepak R Varma wrote: > According to Documentation/filesystems/sysfs.rst, the show() callback > function of kobject attributes should strictly use sysfs_emit() instead > of sprintf() family functions. So, make this change. > Issue identified using the coccinelle device_attr_show.cocci script. > > Signed-off-by: Deepak R Varma > --- Hello, Requesting a review and feedback on this patch proposal. Thank you, ./drv