From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH printk v5 6/8] printk: introduce console_prepend_dropped() for dropped messages
Date: Mon, 9 Jan 2023 15:12:40 +0100 [thread overview]
Message-ID: <Y7wg2AkVs09rrB0v@alley> (raw)
In-Reply-To: <20230109100800.1085541-7-john.ogness@linutronix.de>
On Mon 2023-01-09 11:13:58, John Ogness wrote:
> Currently "dropped messages" are separately printed immediately
> before printing the printk message. Since normal consoles are
> now using an output buffer that is much larger than previously,
> the "dropped message" could be prepended to the printk message
> and then output everything in a single write() call.
>
> Introduce a helper function console_prepend_dropped() to prepend
> an existing message with a "dropped message". This simplifies
> the code by allowing all message formatting to be handled
> together and then only requires a single write() call to output
> the full message. And since this helper does not require any
> locking, it can be used in the future for other console printing
> contexts as well.
>
> Note that console_prepend_dropped() is defined as a NOP for
> !CONFIG_PRINTK. Although the function will never be called for
> !CONFIG_PRINTK, compiling the function can lead to warnings of
> "always true" conditionals due to the size macro values used
> in !CONFIG_PRINTK.
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2023-01-09 14:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 10:07 [PATCH printk v5 0/8] printk: cleanup buffer handling John Ogness
2023-01-09 10:07 ` [PATCH printk v5 1/8] printk: move size limit macros into internal.h John Ogness
2023-01-09 10:07 ` [PATCH printk v5 2/8] console: Use BIT() macros for @flags values John Ogness
2023-01-09 10:07 ` [PATCH printk v5 3/8] console: Document struct console John Ogness
2023-01-09 10:07 ` [PATCH printk v5 4/8] printk: introduce struct printk_buffers John Ogness
2023-01-09 10:07 ` [PATCH printk v5 5/8] printk: introduce printk_get_next_message() and printk_message John Ogness
2023-01-09 10:07 ` [PATCH printk v5 6/8] printk: introduce console_prepend_dropped() for dropped messages John Ogness
2023-01-09 14:12 ` Petr Mladek [this message]
2023-01-09 10:07 ` [PATCH printk v5 7/8] printk: use printk_buffers for devkmsg John Ogness
2023-01-09 14:23 ` Petr Mladek
2023-01-09 10:08 ` [PATCH printk v5 8/8] printk: adjust string limit macros John Ogness
2023-01-09 15:10 ` [PATCH printk v5 0/8] printk: cleanup buffer handling Petr Mladek
2023-01-11 15:36 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7wg2AkVs09rrB0v@alley \
--to=pmladek@suse.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®