From: Pavel Machek <pavel@ucw.cz>
To: Ian Pilcher <arequipeno@gmail.com>
Cc: lee@kernel.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, kabel@kernel.org
Subject: Re: [PATCH v13 1/2] docs: Add block device (blkdev) LED trigger documentation
Date: Mon, 9 Jan 2023 19:05:14 +0100 [thread overview]
Message-ID: <Y7xXWrR3jD3cUxWv@duo.ucw.cz> (raw)
In-Reply-To: <20221227225226.546489-2-arequipeno@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 735 bytes --]
Hi!
This is the crazy interface I'm complaining about:
> * /sys/class/leds/<led>/link_dev_by_path
> * /sys/class/leds/<led>/unlink_dev_by_path
> * /sys/class/leds/<led>/unlink_dev_by_name
> * /sys/class/leds/<led>/linked_devices
Echoing filenames into files (with symlink resolution) is quite
strange, is it? As is having two different unlink interfaces.
I believe we do have other places handling similar N:M configuration
problems, so this should be similar to some of them.
Obvious improvement would be having only "link_dev_by_name" and
"unlink_dev_by_name", but then, unlink should really be rm.
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2023-01-09 18:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 22:52 [PATCH v13 0/2] Introduce block device LED trigger Ian Pilcher
2022-12-27 22:52 ` [PATCH v13 1/2] docs: Add block device (blkdev) LED trigger documentation Ian Pilcher
2023-01-09 18:05 ` Pavel Machek [this message]
2022-12-27 22:52 ` [PATCH v13 2/2] leds: trigger: Add block device LED trigger Ian Pilcher
2023-01-09 16:38 ` [PATCH v13 0/2] Introduce " Lee Jones
2023-03-01 14:27 ` Lee Jones
2023-03-01 17:38 ` Ian Pilcher
2023-03-02 16:04 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7xXWrR3jD3cUxWv@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=arequipeno@gmail.com \
--cc=kabel@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®