From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FEDFC25B4E for ; Sun, 22 Jan 2023 18:26:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230493AbjAVS0a (ORCPT ); Sun, 22 Jan 2023 13:26:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231502AbjAVS0Z (ORCPT ); Sun, 22 Jan 2023 13:26:25 -0500 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1FBF1F90E; Sun, 22 Jan 2023 10:26:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1674411971; bh=sniCASOe1ODyzMu7csbaPtyDibtigv6Yvb8lsLBEXvs=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=jKMsRSjmRZiVW/Z0zbv04IF/CGMJhUwKNNjzEb7MEe+qrHH642H3qHT/9noHqjCEL KO072/MUreEJn3rEVzSVPMePRKErdbJMnLY6gU8MaLwFZwLLX882Vd1nFwlFpJi1bB yU9wMcQVebF4+aVU1KVLKFAuY7jU29EYjNMRb1nE= Received: by b-1.in.mailobj.net [192.168.90.11] with ESMTP via ip-206.mailobj.net [213.182.55.206] Sun, 22 Jan 2023 19:26:11 +0100 (CET) X-EA-Auth: ckDisbBlfERhQdrSU2NzQxmYs3jWb2lFzVG5PGsvP97OQbJtxsIRZldBJ9Bq63tv8IEMFRV8UG/1fD8KXrVOxypOJwJmInsF Date: Sun, 22 Jan 2023 23:56:07 +0530 From: Deepak R Varma To: Satish Kharat , Sesidhar Baddela , Karan Tilak Kumar , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar , Praveen Kumar Subject: Re: [PATCH] scsi: fnic: Use a variable for repeated mem_size computation Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2023 at 11:56:31PM +0530, Deepak R Varma wrote: > Use a variable to upfront compute memory size to be allocated, > instead of repeatedly computing it at different instructions. > The reduced instruction length also allows to tidy up the code. > Issue identified using the array_size_dup Coccinelle semantic > patch. > > Signed-off-by: Deepak R Varma > --- Hello, Any feedback/review comments on this patch proposal please? Thank you, ./drv > drivers/scsi/fnic/fnic_trace.c | 19 +++++++------------ > 1 file changed, 7 insertions(+), 12 deletions(-) > > diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c > index e03967463561..7b8ef74fc060 100644 > --- a/drivers/scsi/fnic/fnic_trace.c > +++ b/drivers/scsi/fnic/fnic_trace.c > @@ -544,12 +544,10 @@ int fnic_fc_trace_init(void) > unsigned long fc_trace_buf_head; > int err = 0; > int i; > + size_t mem_sz = array_size(PAGE_SIZE, fnic_fc_trace_max_pages); > > - fc_trace_max_entries = (fnic_fc_trace_max_pages * PAGE_SIZE)/ > - FC_TRC_SIZE_BYTES; > - fnic_fc_ctlr_trace_buf_p = > - (unsigned long)vmalloc(array_size(PAGE_SIZE, > - fnic_fc_trace_max_pages)); > + fc_trace_max_entries = mem_sz / FC_TRC_SIZE_BYTES; > + fnic_fc_ctlr_trace_buf_p = (unsigned long)vmalloc(mem_sz); > if (!fnic_fc_ctlr_trace_buf_p) { > pr_err("fnic: Failed to allocate memory for " > "FC Control Trace Buf\n"); > @@ -557,13 +555,11 @@ int fnic_fc_trace_init(void) > goto err_fnic_fc_ctlr_trace_buf_init; > } > > - memset((void *)fnic_fc_ctlr_trace_buf_p, 0, > - fnic_fc_trace_max_pages * PAGE_SIZE); > + memset((void *)fnic_fc_ctlr_trace_buf_p, 0, mem_sz); > > /* Allocate memory for page offset */ > - fc_trace_entries.page_offset = > - vmalloc(array_size(fc_trace_max_entries, > - sizeof(unsigned long))); > + mem_sz = array_size(fc_trace_max_entries, sizeof(unsigned long)); > + fc_trace_entries.page_offset = vmalloc(mem_sz); > if (!fc_trace_entries.page_offset) { > pr_err("fnic:Failed to allocate memory for page_offset\n"); > if (fnic_fc_ctlr_trace_buf_p) { > @@ -574,8 +570,7 @@ int fnic_fc_trace_init(void) > err = -ENOMEM; > goto err_fnic_fc_ctlr_trace_buf_init; > } > - memset((void *)fc_trace_entries.page_offset, 0, > - (fc_trace_max_entries * sizeof(unsigned long))); > + memset((void *)fc_trace_entries.page_offset, 0, mem_sz); > > fc_trace_entries.rd_idx = fc_trace_entries.wr_idx = 0; > fc_trace_buf_head = fnic_fc_ctlr_trace_buf_p; > -- > 2.34.1 > > >