From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EA6CC38142 for ; Mon, 23 Jan 2023 15:03:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232166AbjAWPDI (ORCPT ); Mon, 23 Jan 2023 10:03:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232140AbjAWPC6 (ORCPT ); Mon, 23 Jan 2023 10:02:58 -0500 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DF61A252; Mon, 23 Jan 2023 07:02:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QsIsfRz11u76ytKuRg/7ke75KipeBiduQx3nFpUgW40=; b=lORnCktcinTTw0vdbaUqtLvSWU FLKbaxy/LWEaX+OUvNyhDQj/hk3/NndAd0LX9zRtxLWhgUE4jnS/k8JjIHVYQ/zsnTwsEtoSRFC0X 40GoQ4mt2NJ5fkXICxdS0IT+wu2blvZeweZ8nV2bFRYyQJLyyHZQWBAZFaapwGGrclgw0ZaV+cX3R c1I/4f413R4gNe+cycym20RZjqxTQWnq5gKRnjcLSiGeNwsxzyJ81u4YUBCM1kKndswlsGlk7BdYY EfdAW0TT9SsGbb5zpfmHsdhLa5uxhPpqIvEWwehcZd//YGS/2ne1RbGhLqCrBS49iK3S3Z1IJe06a 8XoXrz7w==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pJyKo-001Z3P-0w; Mon, 23 Jan 2023 15:02:10 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 7376A30008D; Mon, 23 Jan 2023 16:02:39 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 52C2A202441DC; Mon, 23 Jan 2023 16:02:39 +0100 (CET) Date: Mon, 23 Jan 2023 16:02:39 +0100 From: Peter Zijlstra To: Tetsuo Handa Cc: Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-perf-users@vger.kernel.org, LKML Subject: Re: [perf] lockdep warning between cpu_add_remove_lock and &dev->mutex. Message-ID: References: <8c3fc3d1-8fed-be22-e0e7-ef1e1ea723ce@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 23, 2023 at 11:10:57PM +0900, Tetsuo Handa wrote: > After applying your diff, lockdep message changed like below. Is this > the reason commit 1704f47b50b5 ("lockdep: Add novalidate class for > dev->mutex conversion") was applied? No, reason was device probing itself. There should be a thread about that with Alan Stern some 15 years ago or so. I'll try and have a look at the new splat later today.