From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBD20C61DB3 for ; Thu, 12 Jan 2023 13:23:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229819AbjALNXi (ORCPT ); Thu, 12 Jan 2023 08:23:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232099AbjALNXY (ORCPT ); Thu, 12 Jan 2023 08:23:24 -0500 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06E7139FA6; Thu, 12 Jan 2023 05:23:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673529803; x=1705065803; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=1PTv1lDpHp6a2TJ4NRR5GKeQ0sdk0umVwo/CpE1OPbU=; b=LWsChcUu7MDZAAW8lR9I1/p+WKhpD/P5Eq7wW1T8LLMrAa0XN3oBd+vA k/SjHoFPVXJFWDoMc/jGtZqo6i5JhwfgYZsgqTDiO/SoIs5BHUgCgeD7L 2HgZg4J0bmBwMi1EwP0XvLrF77XKvSDaTTmY8tchcvWpWwZsf2XDrqDG3 fi2SoBRjWtA0PUoh+alaaxfSBnWMjw9U2qX5Vjpu+KlemPvVLEpaUw5ie ozCjyGCpkYr5zvKFZHpCt2+xIPWQinttdTjEETbyov1eGvb+ifH6AlEWY rRwmBOu9J8oEbuyXNe4DRBdopvr0f18XeZX+YS8lbokiqJD952Ju8bUPY Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10587"; a="311525496" X-IronPort-AV: E=Sophos;i="5.97,319,1669104000"; d="scan'208";a="311525496" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2023 05:23:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10587"; a="800208195" X-IronPort-AV: E=Sophos;i="5.97,319,1669104000"; d="scan'208";a="800208195" Received: from kuha.fi.intel.com ([10.237.72.185]) by fmsmga001.fm.intel.com with SMTP; 12 Jan 2023 05:23:18 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Thu, 12 Jan 2023 15:23:18 +0200 Date: Thu, 12 Jan 2023 15:23:18 +0200 From: Heikki Krogerus To: Prashant Malani Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, bleung@chromium.org, stable@vger.kernel.org, Greg Kroah-Hartman , Guillaume Ranquet , Macpaul Lin , Pablo Sun Subject: Re: [PATCH 2/3] usb: typec: altmodes/displayport: Fix pin assignment calculation Message-ID: References: <20230111020546.3384569-1-pmalani@chromium.org> <20230111020546.3384569-2-pmalani@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230111020546.3384569-2-pmalani@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2023 at 02:05:42AM +0000, Prashant Malani wrote: > Commit c1e5c2f0cb8a ("usb: typec: altmodes/displayport: correct pin > assignment for UFP receptacles") fixed the pin assignment calculation > to take into account whether the peripheral was a plug or a receptacle. > > But the "pin_assignments" sysfs logic was not updated. Address this by > using the macros introduced in the aforementioned commit in the sysfs > logic too. > > Fixes: c1e5c2f0cb8a ("usb: typec: altmodes/displayport: correct pin assignment for UFP receptacles") > Cc: stable@vger.kernel.org > Cc: Heikki Krogerus > Signed-off-by: Prashant Malani Reviewed-by: Heikki Krogerus > --- > drivers/usb/typec/altmodes/displayport.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c > index f9d4a7648bc9..c0d65c93cefe 100644 > --- a/drivers/usb/typec/altmodes/displayport.c > +++ b/drivers/usb/typec/altmodes/displayport.c > @@ -427,9 +427,9 @@ static const char * const pin_assignments[] = { > static u8 get_current_pin_assignments(struct dp_altmode *dp) > { > if (DP_CONF_CURRENTLY(dp->data.conf) == DP_CONF_DFP_D) > - return DP_CAP_UFP_D_PIN_ASSIGN(dp->alt->vdo); > + return DP_CAP_PIN_ASSIGN_DFP_D(dp->alt->vdo); > else > - return DP_CAP_DFP_D_PIN_ASSIGN(dp->alt->vdo); > + return DP_CAP_PIN_ASSIGN_UFP_D(dp->alt->vdo); > } > > static ssize_t > -- > 2.39.0.314.g84b9a713c41-goog -- heikki