mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tj@kernel.org" <tj@kernel.org>
To: "Lixiong Liu (刘利雄)" <Lixiong.Liu@mediatek.com>
Cc: "lizefan@huawei.com" <lizefan@huawei.com>,
	"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
	"Wenju Xu (许文举)" <Wenju.Xu@mediatek.com>,
	wsd_upstream <wsd_upstream@mediatek.com>,
	"Jing-Ting Wu (吳靜婷)" <Jing-Ting.Wu@mediatek.com>,
	"WJ Wang (王军)" <wj.wang@mediatek.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Andress Kuo (郭孟修)" <Andress.Kuo@mediatek.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Subject: Re: cgroup user-after-free
Date: Thu, 12 Jan 2023 15:14:30 -1000	[thread overview]
Message-ID: <Y8Cwdsk5pYNd8fX8@slm.duckdns.org> (raw)
In-Reply-To: <697032f2331a92eec0e03e85e46cb78bd975a788.camel@mediatek.com>

On Thu, Jan 12, 2023 at 09:48:55AM +0000, Lixiong Liu (刘利雄) wrote:
> Hi,
> 
> We meet cgroup use-after-free happened in T SW version with 
> 
> kernel-5.15.
>  
> Root cause: 
> cgroup_migrate_finish free cset’s cgroup,
> 
> but cgroup_sk_alloc use the freed cgroup,
> 
> then use-after-free happened.

Sounds similar to the problem fixed by 07fd5b6cdf3c ("cgroup: Use separate
src/dst nodes when preloading css_sets for migration"). Can you try it out?

Thanks.

-- 
tejun

  reply	other threads:[~2023-01-13  1:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12  9:48 Lixiong Liu (刘利雄)
2023-01-13  1:14 ` tj [this message]
2023-01-13  5:40   ` Lixiong Liu (刘利雄)
2023-02-01  6:04     ` Lixiong Liu (刘利雄)
2023-02-02 19:50       ` tj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8Cwdsk5pYNd8fX8@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=Andress.Kuo@mediatek.com \
    --cc=Jing-Ting.Wu@mediatek.com \
    --cc=Lixiong.Liu@mediatek.com \
    --cc=Wenju.Xu@mediatek.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=lizefan@huawei.com \
    --cc=matthias.bgg@gmail.com \
    --cc=wj.wang@mediatek.com \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®